develooper Front page | perl.perl5.porters | Postings from January 2001

Re: `Final' lvsub patch: arrays and hashes

Thread Previous | Thread Next
Simon Cozens
January 5, 2001 05:44
Re: `Final' lvsub patch: arrays and hashes
Message ID:
On Thu, Jan 04, 2001 at 11:08:12PM -0800, Stephen McCamant wrote:
> * Checking for real syntactic lvalue-ness significantly narrows the
>   range of what subs can be lvalues.

Hold on, you're not actually doing that. I don't see what you're doing that
affects it, and if you are doing something that affects it, stop. :)

This patch looks to be going very much in the right direction, on the whole.

> -	case OP_RETURN:
> -	    if (o->op_next && o->op_next->op_type != OP_LEAVESUBLV) {
> -		o->op_seq = PL_op_seqmax++;
> -		break;
> -	    }
> -	    /* FALL THROUGH */

Uhm, why have you done that?

> +    if (cxstack[cxix].blk_sub.lval && CvLVALUE(cxstack[cxix]
> +	return cxstack[cxix].blk_sub.lval;

return 1?

Apart from that, it looks great. *Looks* great. Obviously we don't want the
subfaults... :)

    Never be Afraid to Share Your Dreams with the World,
    Because there's Nothing the World Loves More Than The Taste of
    Really Sweet Dreams                    

Thread Previous | Thread Next Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at | Group listing | About