develooper Front page | perl.perl5.porters | Postings from December 2000

Re: [PATCH blead] Fix B::Terse indentation

Thread Previous
From:
Jarkko Hietaniemi
Date:
December 28, 2000 14:55
Subject:
Re: [PATCH blead] Fix B::Terse indentation
Message ID:
20001228165504.B19382@chaos.wustl.edu
On Thu, Dec 28, 2000 at 02:47:23PM -0800, Daniel Chetlin wrote:
> On Thu, Dec 28, 2000 at 03:20:10PM -0600, Jarkko Hietaniemi wrote:
> > On Wed, Dec 27, 2000 at 06:43:30AM -0800, Daniel Chetlin wrote:
> > > Simon noticed yesterday that the indentation for B::Terse is broken. It
> > > appears that B::Terse used walkoptree_slow() for a reason: it provides
> > > the levels necessary for indentation. Change #8072 switched Terse (and
> > > B::Lint) to using the fast XS version of walkoptree().
> > 
> > Unnhhh.  The walkop* changes seem to be a veritable mess, it's like
> > trying to sleep with a too small blanket...  I'm seriously considering
> > pulling out all the related patches, starting from #7848, so we can
> > (re)start from a clean slate.
> 
> I am fairly certain that all is well now, and the only difference
> between the state of things now and the state they were at before #7848
> is that B::Lint is using the XS version of walkoptree and there's a
> helpful illuminating comment in B.pm. So I don't think there's much to
> be gained.
> 
> I would like to rewrite the XS version of walkoptree to take a level,
> but I don't know if that would fly. Are there things out of the core
> (i.e. things that I can't patch) which are using the current version? I

Very unlikely, the B:: things are so vaporous.  So go ahead.

> suppose another alternative would be to write walkoptree_level, and then
> kill walkoptree_slow (or alias it to _level).
> 
> But I don't think there's a need for any further fighting over the
> blankets.
> 
> -dlc

-- 
$jhi++; # http://www.iki.fi/jhi/
        # There is this special biologist word we use for 'stable'.
        # It is 'dead'. -- Jack Cohen

Thread Previous


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About