develooper Front page | perl.perl5.porters | Postings from December 2000

Re: [PATCH blead] Fix B::Terse indentation

Thread Previous | Thread Next
From:
Jarkko Hietaniemi
Date:
December 28, 2000 13:20
Subject:
Re: [PATCH blead] Fix B::Terse indentation
Message ID:
20001228152010.H13925@chaos.wustl.edu
On Wed, Dec 27, 2000 at 06:43:30AM -0800, Daniel Chetlin wrote:
> Simon noticed yesterday that the indentation for B::Terse is broken. It
> appears that B::Terse used walkoptree_slow() for a reason: it provides
> the levels necessary for indentation. Change #8072 switched Terse (and
> B::Lint) to using the fast XS version of walkoptree().

Unnhhh.  The walkop* changes seem to be a veritable mess, it's like
trying to sleep with a too small blanket...  I'm seriously considering
pulling out all the related patches, starting from #7848, so we can
(re)start from a clean slate.

> After trawling through Lint, I can't find any good reason it can't be
> using the fast version (is anyone using Lint, anyways?), but Terse
> definitely needs the slow one, unless we want to change the call
> signature of walkoptree(). Plus, who the heck needs the extra speed
> increase when running Terse?
> 
> At any rate, the good thing about all of this is that I now understand
> B. B::Deparse, however, remains a terrifying monster.
> 
> -dlc

-- 
$jhi++; # http://www.iki.fi/jhi/
        # There is this special biologist word we use for 'stable'.
        # It is 'dead'. -- Jack Cohen

Thread Previous | Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About