develooper Front page | perl.perl5.porters | Postings from December 2000

Patch 8204 has a reject

Thread Next
From:
andreas.koenig
Date:
December 24, 2000 13:38
Subject:
Patch 8204 has a reject
Message ID:
m3k88ppkij.fsf@ak-71.mind.de
Patch 8204 does not apply cleanly, hunk 2 fails.

You can easily reproduce the failure by doing the following (assuming
the ../diffs/ directory contains the patches):

  mkdir -p t/op
  touch t/op/utf8decode.t
  for n in 7996 8028 8037 8143 8204; do
    echo $n
    PATCH=../diffs/$n.gz
    zcat $PATCH | patch -p1 -N -l
  done

and answering any questions with a RETURN.

After that you will find the files

      7442  t/op/utf8decode.t
      7511  t/op/utf8decode.t.orig
     13684  t/op/utf8decode.t.rej

Culprit is in lines 58ff of that utf8decode.t. Line 58 is (backslashes
at end of line added by me):

3.2.1 n "\300 \301 \302 \303 \304 \305 \306 \307 \310 \311 \312 \313 \314 \315 \
\316 \317 \320 \321 \322 \323 \324 \325 \326 \327 \330 \331 \332 \333 \334 \335\
 \336 \337 "      -       64      c0:20:c1:20:c2:20:c3:20:c4:20:c5:20:c6:20:c7:\
20:c8:20:c9:20:ca:20:cb:20:cc:20:cd:20:ce:20:cf:20:d0:20:d1:20:d2:20:d3:20:d4:2\
0:d5:20:d6:20:d7:20:d8:20:d9:20:da:20:db:20:dc:20:dd:20:de:20:df:20 -       une\
xpected non-continuation byte 0x20 after byte 0xc0

But the patch contains

- 3.2.1 n "\300 \301 \302 \303 \304 \305 \306 \307 \310 \311 \312 \313 \314 \31\
5 \316 \317 \320 \321 \322 \323 \324 \325 \326 \327 \330 \331 \332 \333 \334 \3\
35 \336 \337 "    -       64      c0:20:c1:20:c2:20:c3:20:c4:20:c5:20:c6:20:c7:\
20:c8:20:c9:20:ca:20:cb:20:cc:20:cd:20:ce:20:cf:20:d0:20:d1:20:d2:20:d3:20:d4:2\
0:d5:20:d6:20:d7:20:d8:20:d9:20:da:20:db:20:dc:20:dd:20:de:20:df:20 -       une\
xpected non-continuation byte 0x20 after start byte 0xc0

The difference is the word "start" near the end of line. Same problem
in line 59, 60, 61, 62. A similar fault appears in line 75 in the word
"continuation" vs. "non-continuation".

-- 
andreas

Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About