develooper Front page | perl.perl5.porters | Postings from December 2000

Re: Bleadperl [@8143] didn't compile

Thread Previous | Thread Next
From:
Gerrit P. Haase
Date:
December 17, 2000 10:56
Subject:
Re: Bleadperl [@8143] didn't compile
Message ID:
3A3D1A8F.2690.1A662743@localhost
I got still the same error after another make distclean:
 
> > > > Line 2097, config.h:
> > > > /* HAS_STRTOQ:
> > > >  *	This symbol, if defined, indicates that the strtoq routine is
> > > >  *	available to convert strings to long longs (quads).
> > > >  */
> > > > # HAS_STRTOQ		/**/
>       ^^^^^^
> here is 'define' missing after configure.
>  
> > > > I don't know, where to change s.th., looked in config.sh and 
> > > > config_h.SH, but didn't figured out what to change.

For the second error (mg.c) i made a little change now, so it seems to 
compile o.k, but i don't know, if it is o.k., because i'm not a c-
programmer, and i don't know, what the meaning of all the functions in 
mg.c is.

> Also got an error after fixing config.h, where is s.th wrong in mg.c:
> 
> `sh  cflags libperl5_7_0 mg.o`  mg.c
>           CCCMD =  gcc -DPERL_CORE -c -DPERL_USE_SAFE_PUTENV -fno-
> strict-aliasing -I/usr/local/include -O2
> mg.c: In function `Perl_magic_len':
> mg.c:406: warning: passing arg 1 of `Perl_utf8_length' from 
> incompatible pointer type
> mg.c:406: too few arguments to function `Perl_utf8_length'
> make: *** [mg.o] Error 1
> [...]
> make: Target `all' not remade because of errors.

However, here is my patch, with it and fixing config.h, perl@8143 
compiled as usual. But, as i said above, check if it makes sense.

===BEGIN PATCH===

$ diff -ur mg.c~ mg.c
--- mg.c~       Sun Dec 17 17:57:54 2000
+++ mg.c        Sun Dec 17 18:09:13 2000
@@ -403,7 +403,7 @@
                    char *s    = rx->subbeg + s1;
                    char *send = rx->subbeg + t1;

-                   i = Perl_utf8_length((U8*)s, (U8*)send);
+                   i = Perl_utf8_length(aTHX_(U8*)s, (U8*)send );
                }
                if (i < 0)
                    Perl_croak(aTHX_ "panic: magic_len: %d", i);

===END OF PATCH===

Also got test errors ($ uname -a
CYGWIN_NT-4.0 LORELEY 1.1.7s(0.31/3/2) 2000-12-04 23:55 i686 unknown):

Failed Test      Status Wstat Total Fail  Failed  List of Failed
------------------------------------------------------------------------
io/utf8.t                             25    1   4.00%  19
lib/glob-basic.t                       9    1  11.11%  3
4 tests and 108 subtests skipped.
Failed 2/277 test scripts, 99.28% okay. 2/21063 subtests failed, 99.99% 
okay.

glob-basic is clear, maybe it is possible to add this:

===PATCH===

$ diff -ur glob-basic.t~ glob-basic.t
--- glob-basic.t~       Tue Dec 12 03:31:55 2000
+++ glob-basic.t        Sun Dec 17 18:51:02 2000
@@ -39,7 +39,7 @@

 # look up the user's home directory
 # should return a list with one item, and not set ERROR
-if ($^O ne 'MSWin32' && $^O ne 'VMS') {
+if ($^O ne 'MSWin32' && $^O ne 'VMS' && $^O ne 'cygwin') {
   eval {
     ($name, $home) = (getpwuid($>))[0,7];
     1;

===END PATCH===
-- 
Gerrit Peter Haase

Thread Previous | Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About