develooper Front page | perl.perl5.porters | Postings from December 2000

[PATCH] Re: Breadperl & Tk

From:
Nick Ing-Simmons
Date:
December 12, 2000 06:48
Subject:
[PATCH] Re: Breadperl & Tk
Message ID:
200012121447.OAA11510@mikado.tiuk.ti.com
Nick Ing-Simmons <nik@tiuk.ti.com> writes:

>B. When I fix A in Tk sources it core dumps in a manner which suggests
>   something has done heap-overrun.

This is a weird one. SPARC/gcc-2.95.2 was botching the test-for-hibit 
code in sv_utf8_upgrade and give false positives. (Which is bad
news and I have submitted GNATS report to gcc.) But it seems all that does
is exercise the "representation does not matter" aspect of SvUTF8 ;-)

It also forced us to confront the case where it tried to upgrade and 
Safefree() an SvFAKE sv (or indeed any other SvLEN == 0 non-malloced case).

This then lead to the core dumps.

Patch moves the hibit init out of the for loop, makes it an int not a bool (char)
either of which fixes false +ve bug on SPARC/gcc. And corrects the other
two issues for when they really occur.


-- 
Nick Ing-Simmons <nik@tiuk.ti.com>
Via, but not speaking for: Texas Instruments Ltd.




nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About