develooper Front page | perl.perl5.porters | Postings from November 2000

[ID 20001122.002] [PATCH 5.7.0@7795] two small patches to perlbug

Thread Next
From:
Philip Newton
Date:
November 22, 2000 05:26
Subject:
[ID 20001122.002] [PATCH 5.7.0@7795] two small patches to perlbug
Message ID:
3A1BD771.25462.1939FAD@localhost
This is a bug report for perl from pnewton@gmx.de,
generated with the help of perlbug 1.26 running under perl 5.00503.


-----------------------------------------------------------------
[Please enter your report here]

(I think sendmail isn't working on the system I installed
5.7.0@7795 on and the previous report didn't get sent. If you've
seen this report before, you can ignore it. Ignore the configuration
information perlbug put on this report since it's not the Perl I'm
talking about. In fact, I'll just snip the bottom off.)

Two small patches for Perlbug. First off, when asking for options
after saving a file, matches are case insensitive -- except for the
^s test that's not ^sa nor ^se. I believe this should also be
case insensitive.

Second, sendmail is called with the -t flag; I believe one should
also include -oi to ignore dots in messages. Otherwise you might
run into trouble if some, accidentally or on purpose, puts a line
into his report consisting only of a dot, since AIUI sendmail
would terminate transmission at that point.

These are really two separate patches; if you decide to apply one
and not the other, I'll be happy to submit them separately if that
makes it easier for you.

$ diff -c perlbug.orig perlbug
*** perlbug.orig        Wed Nov 22 12:45:20 2000
--- perlbug     Wed Nov 22 14:00:40 2000
***************
*** 709,715 ****
                Edit();
            } elsif ($action =~ /^[qc]/i) { # <C>ancel, <Q>uit
                Cancel();
!           } elsif ($action =~ /^s/) {
                paraprint <<EOF;
  I'm sorry, but I didn't understand that. Please type "send" or "save".
  EOF
--- 709,715 ----
                Edit();
            } elsif ($action =~ /^[qc]/i) { # <C>ancel, <Q>uit
                Cancel();
!           } elsif ($action =~ /^s/i) {
                paraprint <<EOF;
  I'm sorry, but I didn't understand that. Please type "send" or "save".
  EOF
***************
*** 777,783 ****
  So you may attempt to find some way of sending your message, it has
  been left in the file `$filename'.
  EOF
!       open(SENDMAIL, "|$sendmail -t") || die "'|$sendmail -t' failed: $!";
  sendout:
        print SENDMAIL "To: $address\n";
        print SENDMAIL "Subject: $subject\n";
--- 777,783 ----
  So you may attempt to find some way of sending your message, it has
  been left in the file `$filename'.
  EOF
!       open(SENDMAIL, "|$sendmail -t -oi") || die "'|$sendmail -t' failed: $!";
  sendout:
        print SENDMAIL "To: $address\n";
        print SENDMAIL "Subject: $subject\n";

End of patch.

Cheers,
Philip



Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About