develooper Front page | perl.perl5.porters | Postings from November 2000

Re: Patching on devel track malfuncioning

From:
Gurusamy Sarathy
Date:
November 15, 2000 22:13
Subject:
Re: Patching on devel track malfuncioning
Message ID:
200011160611.eAG6BWs23933@smtp3.ActiveState.com
On Wed, 15 Nov 2000 21:19:45 PST, Gurusamy Sarathy wrote:
>>2) Patch 7642 says
>>
>>Reversed (or previously applied) patch detected!  Skipping
>> patch.
>>1 out of 1 hunk ignored -- saving rejects to lib/ExtUtils/MM_Cygwin.pm.rej
>
>The patch is correct.  I suspect your sources somehow got muddled.
>p4 print //depot/perl/lib/ExtUtils/MM_Cygwin.pm@7641 doesn't show
>the two lines that are being added by the patch, contrary to what
>you said.  The last edit to MM_Cygwin.pm happened at change#5008
>(i.e. before 5.6.0) and you'll note the 5.6.0 version of the file
>doesn't have those lines either.

But the 5.7.0 version of it has those two lines!

`diff -ruN perl@7015 perl-5.7.0` shows that those two lines somehow
got into the 5.7.0 release even though they were never checked into
the repository or logged in Changes before change#7642.

I've commented out the offending hunk.

>>3) Patch 7685 says
>>
>>1 out of 14 hunks FAILED -- saving rejects to perlio.c.rej
>
>This appears to be the same issue as item 2 above.  The patch
>is showing the right edit, and the deleted lines are there at
>that rev, so I'm not sure how you're getting the problem.

Scratch that.  It was due to a missing patch in the APC, change#7635.
Now added.


Sarathy
gsar@ActiveState.com



nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About