develooper Front page | perl.perl5.porters | Postings from November 2000

Re: Patching on devel track malfuncioning

From:
andreas.koenig
Date:
November 15, 2000 20:18
Subject:
Re: Patching on devel track malfuncioning
Message ID:
m366lok0rh.fsf@ak-71.mind.de
>>>>> On Wed, 15 Nov 2000 08:29:57 -0600, Jarkko Hietaniemi <jhi@iki.fi> said:

 >> 1) Patch 7632 says
 >> 
 >> Reversed (or previously applied) patch detected!  Skipping
 >> patch.
 >> 1 out of 1 hunk ignored -- saving rejects to lib/unicode/syllables.txt.rej

  > Probably caused because syllables.txt used to be CRLF-delimited file and
  > I converted it into LF-delimited one.

Sorry, I should have figured that out myself. As I am removing CRs
*before* patching, of course patch could not find them anymore. I can
deal with that:-)

 >> 2) Patch 7642 says
 >> 
 >> Reversed (or previously applied) patch detected!  Skipping
 >> patch.

  > Ditto.  Are you using patch --ignore-whitespace?

No, I'm not using --ignore-whitespace. And I see no CRs in 7642.

 >> 1 out of 1 hunk ignored -- saving rejects to lib/ExtUtils/MM_Cygwin.pm.rej
 >> 

Look:

+        grep { $self->{MAN1PODS}{$_} =~ s/::/./g } keys %{$self->{MAN1PODS}};
+        grep { $self->{MAN3PODS}{$_} =~ s/::/./g } keys %{$self->{MAN3PODS}};

This patch really seems wrong to me, these two lines that are being
added to MM_Cygwin are already in perl-5.7.0 and have not been removed
since. At least not in the available patches.

 >> 4) And Configure complains
 >> 
 >> First let's make sure your kit is complete.  Checking...
 >> ls: ext/Encode/Encode/iso8859-10.enc: No such file or directory
 >> ls: ext/Encode/Encode/iso8859-13.enc: No such file or directory
 >> ls: ext/Encode/Encode/iso8859-14.enc: No such file or directory
 >> ls: ext/Encode/Encode/iso8859-15.enc: No such file or directory

  > These files were supposed to be added to MANIFEST back in patch 7640.

Yes, they were added to MANIFEST, but the patch did not contain the
files themselves because they were considered binary:

  ==== //depot/perl/ext/Encode/Encode/iso8859-10.enc#1 (binary) ====
  ==== //depot/perl/ext/Encode/Encode/iso8859-13.enc#1 (binary) ====
  ==== //depot/perl/ext/Encode/Encode/iso8859-14.enc#1 (binary) ====
  ==== //depot/perl/ext/Encode/Encode/iso8859-15.enc#1 (binary) ====


-- 
andreas



nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About