Front page | perl.perl5.porters |
Postings from November 2000
Jarkko Hietaniemi <jhi@iki.fi> writes:
>> *** perlsdio.h.FCS Tue Nov 14 10:50:12 2000
>> ! #define PerlIO_set_ptrcnt(f,p,c) STMT_START {FILE_ptr(f) = (p), PerlIO_set_cnt(f,c);} STMT_END
>> /* assert() may pre-process to ""; potential syntax error (FILE_ptr(), ) */
>> ! #define PerlIO_set_ptrcnt(f,p,c) STMT_START {FILE_ptr(f) = (p); assert(FILE_cnt(f) == (c));} STMT_END
>
>Could you explain the reason for these added assert()s a little bit more...?
I think he just started from something which had them.
I dislike the
! #if defined(sun) && !defined(_LP64)
even more !
Sun in _LP64 mode should be handled by the Configure stuff - as I understand
it in _LP64 mode FILE * is opaque - and so FILE_ptr et. al. should
not be defined at all.
What the patch is attempting to do is handle the fact that Configure
has mis-guessed STDCHAR because FILE is defined under another name
in file other than <stdio.h>. It would be better handled
with a hints file that set STDCHAR
--
Nick Ing-Simmons <nik@tiuk.ti.com>
Via, but not speaking for: Texas Instruments Ltd.
Thread Previous
|
Thread Next