develooper Front page | perl.perl5.porters | Postings from November 2000

Re: [ID 20001114.002] Code-Cleanups concerning SOCKS5 and Solaris

Thread Previous | Thread Next
From:
Jarkko Hietaniemi
Date:
November 14, 2000 05:36
Subject:
Re: [ID 20001114.002] Code-Cleanups concerning SOCKS5 and Solaris
Message ID:
20001114073550.A27286@chaos.wustl.edu
> These fix warnings reported by the Sun Forte C 6.0 compiler and
> errors reported by gcc 2.95.1, when SOCKS5 support is configured in.
> Mainly some prototype changes result in (unsigned int*) values being (int *)

Otherwise the patch looks good but these

#ifdef SOCKS
...(int *)&foo
#else
...&foo
#endif

spots I don't much love because they create brittle #ifdef code all
over the place, for a very little gain.  I'll try to think of something.
(Maybe Configure needs to be thought to use -DSOCKS when probing for
things socket.)

-- 
$jhi++; # http://www.iki.fi/jhi/
        # There is this special biologist word we use for 'stable'.
        # It is 'dead'. -- Jack Cohen

Thread Previous | Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About