develooper Front page | perl.perl5.porters | Postings from November 2000

Re: [ID 20001107.014] Not OK: perl v5.7.0 +DEVEL7594 on dos-djgpp djgpp

Thread Previous | Thread Next
From:
Jarkko Hietaniemi
Date:
November 7, 2000 20:01
Subject:
Re: [ID 20001107.014] Not OK: perl v5.7.0 +DEVEL7594 on dos-djgpp djgpp
Message ID:
20001107220129.A5784@chaos.wustl.edu
On Tue, Nov 07, 2000 at 09:39:52PM -0500, Peter J. Farley III wrote:
> This is a build failure report for perl from pjfarley@banet.net,
> generated with the help of perlbug 1.32 running under perl v5.7.0.
> 
> 
> -----------------------------------------------------------------
> [Please enter your report here]
> 
> t/pragma/warnings.t fails on pp_flock test.
> 
> Patch:  Add "... or ($^O eq 'dos')" to pp_flock test in file
>          t/pragma/warn/pp_sys
> 
> Patch file attached and pasted here.
> 
> ------------------Begin patch paste-----------------------------
> --- t/pragma/warn/pp_sys.orig	Sun Oct 22 18:38:28 2000
> +++ t/pragma/warn/pp_sys.	Tue Nov  7 21:08:28 2000
> @@ -203,7 +203,7 @@
>   # pp_sys.c [pp_flock]
>   use Config;
>   BEGIN {
> -  if ( $^O eq 'VMS' and ! $Config{d_flock}) {
> +  if ( (($^O eq 'VMS') or ($^O eq 'dos')) and ! $Config{d_flock}) {
>       print <<EOM ;
>   SKIPPED
	
I think I prefer something like this, using the brand new d_fnctl_can_lock:

  if ( !$Config{d_flock} &&
       !$Config{d_fcntl_can_lock} &&
       !$Config{d_lockf} ) {

This should work for dos, too?

-- 
$jhi++; # http://www.iki.fi/jhi/
        # There is this special biologist word we use for 'stable'.
        # It is 'dead'. -- Jack Cohen

Thread Previous | Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About