develooper Front page | perl.perl5.porters | Postings from November 2000

[PATCH] perlbug.PL

From:
Kurt D. Starsinic
Date:
November 6, 2000 18:38
Subject:
[PATCH] perlbug.PL
Message ID:
20001106213901.B20955@O2.chapin.edu
Hi,

    Why does perlbug insist on dumping to a file when stdout isn't a tty?
I suppose that it kind of makes sense for people who don't want to RTFM,
so that they can go `perlbug -ok > dumpfile' without learning that `-d'
will do what they want.  It kind of stinks for `Configure -des &&
make all test ok', though.

    - Kurt

P.S.  Despite my grouchy comments, if anybody finds the current behavior
useful, I'll be happy to send a new patch with a `send the email anyway
even though stdout isn't a tty' flag.  It just doesn't seem obviously
useful to me.

--- utils/perlbug.PL.orig  Tue Oct 31 09:02:48 2000
+++ utils/perlbug.PL       Mon Nov  6 21:25:15 2000
@@ -91,7 +91,7 @@
     $::HaveUtil = ($@ eq "");
 };
 
-my $Version = "1.32";
+my $Version = "1.33";
 
 # Changed in 1.06 to skip Mail::Send and Mail::Util if not available.
 # Changed in 1.07 to see more sendmail execs, and added pipe output.
@@ -128,6 +128,7 @@
 # Changed in 1.30 Added warnings on failure to open files MSTEVENS 13-07-2000
 # Changed in 1.31 Add checks on close().Fix my $var unless. TJENNESS 26-07-2000
 # Changed in 1.32 Use File::Spec->tmpdir TJENNESS 20-08-2000
+# Changed in 1.33 Don't require -t STDOUT for -ok.
 
 # TODO: - Allow the user to re-name the file on mail failure, and
 #       make sure failure (transmission-wise) of Mail::Send is
@@ -153,7 +154,6 @@
 EOF
     die "\n";
 }
-if (!-t STDOUT && !$outfile) { Dump(*STDOUT); exit; }
 
 Query();
 Edit() unless $usefile || ($ok and not $::opt_n);
@@ -896,8 +896,7 @@
         this if you don't give it here.
   -e    Editor to use.
   -t    Test mode. The target address defaults to `$testaddress'.
-  -d    Data mode (the default if you redirect or pipe output.)
-        This prints out your configuration data, without mailing
+  -d    Data mode.  This prints out your configuration data, without mailing
         anything. You can use this with -v to get more complete data.
   -A    Don't send a bug received acknowledgement to the return address.
   -ok   Report successful build on this system to perl porters




nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About