develooper Front page | perl.perl5.porters | Postings from October 2000

[Chris Winters <cwinters@intes.net>] patch to ExtUtils::Manifest

Thread Next
From:
andreas.koenig
Date:
October 29, 2000 13:06
Subject:
[Chris Winters <cwinters@intes.net>] patch to ExtUtils::Manifest
Message ID:
m3snpfqrwo.fsf@ak-71.mind.de
Chris Winters sent me this patch and I'd commend its application.
Thanks Chris!

>>>>> On Mon, 23 Oct 2000 16:56:00 -0400, Chris Winters <cwinters@intes.net> said:

  > I've been using ExtUtils::Manifest and thought that something
  > should work a little differently. In the docs you say that setting
  > $ExtUtils::Manifest::Quiet will make all the functions
  > silent. However, since you're calling File::Path::mkpath with a
  > hardcoded '1' for the 'verbose' parameter, it still spits out the
  > paths as it creates them.

-- 
andreas


--- lib/ExtUtils/Manifest.pm~	Sun Oct 29 21:33:09 2000
+++ lib/ExtUtils/Manifest.pm	Sun Oct 29 21:44:12 2000
@@ -187,13 +187,13 @@
     require File::Basename;
     my(%dirs,$file);
     $target = VMS::Filespec::unixify($target) if $Is_VMS;
-    File::Path::mkpath([ $target ],1,$Is_VMS ? undef : 0755);
+    File::Path::mkpath([ $target ],! $Quiet,$Is_VMS ? undef : 0755);
     foreach $file (keys %$read){
 	$file = VMS::Filespec::unixify($file) if $Is_VMS;
 	if ($file =~ m!/!) { # Ilya, that hurts, I fear, or maybe not?
 	    my $dir = File::Basename::dirname($file);
 	    $dir = VMS::Filespec::unixify($dir) if $Is_VMS;
-	    File::Path::mkpath(["$target/$dir"],1,$Is_VMS ? undef : 0755);
+	    File::Path::mkpath(["$target/$dir"],! $Quiet,$Is_VMS ? undef : 0755);
 	}
 	cp_if_diff($file, "$target/$file", $how);
     }



Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About