Front page | perl.perl5.porters |
Postings from September 2000
On Fri, 15 Sep 2000 20:48:00 +0100, Simon Cozens wrote (in part):
Simon> [20000901.097] undef . utf8
Simon> I'd say you've fixed that; the patch looks great.
Simon> Jarkko/Nick - could you apply?
Actually, it doesn't look great. It leaves the undef warning for
that case, even though .= isn't supposed to generate one. This
one does the right thing here, both for the resulting string and
the undef warning. The right thing to do isn't to force POK on
at the end, but rather at the beginning.
--s.
--- pp_hot.c.DIST Mon Sep 11 06:01:59 2000
+++ pp_hot.c Fri Sep 15 16:15:25 2000
@@ -163,6 +163,10 @@ PP(pp_concat)
/* Take a copy since we're about to overwrite TARG */
olds = s = (U8*)savepvn((char*)s, len);
}
+ if (SvGMAGICAL(left))
+ mg_get(left);
+ else if (!SvOK(left) && SvTYPE(left) <= SVt_PVMG)
+ sv_setpv(left, ""); /* Suppress warning. */
l = (U8*)SvPV(left, targlen);
if (TARG != left)
sv_setpvn(TARG, (char*)l, targlen);
Thread Previous
|
Thread Next