develooper Front page | perl.perl5.porters | Postings from July 2000

[PATCH: perl@6409] bug fix for munchconfig (turned up by CXX)

Thread Next
From:
Peter Prymmer
Date:
July 25, 2000 18:57
Subject:
[PATCH: perl@6409] bug fix for munchconfig (turned up by CXX)
Message ID:
Pine.OSF.4.10.10007251805350.294719-100000@aspara.forte.com

It is sometimes funny what a different compiler can turn up:

 $ cxx/version
 DEC C++ V6.1-003 on OpenVMS Alpha V7.1
 $ cxx munchconfig.c

         if (isalnum(LineBuffer[TildeLoop]) || (LineBuffer[TildeLoop] =
 ..............................................^
 %CXX-W-ASSCOMMEA, use of "=" where "==" may have been intended
 at line number 348 in file DKB100:[PERL.JUNK.JJ]MUNCHCONFIG.C;1

Here is a patch:

--- vms/munchconfig.c_orig	Fri Apr 30 05:04:05 1999
+++ vms/munchconfig.c	Tue Jul 25 18:16:08 2000
@@ -345,8 +345,7 @@
         
       } else {
         /* 'Kay, not a tilde. Is it a word character? */
-        if (isalnum(LineBuffer[TildeLoop]) || (LineBuffer[TildeLoop] =
-                                              '-') ||
+        if (isalnum(LineBuffer[TildeLoop]) ||
             (LineBuffer[TildeLoop] == '-')) {
           TempTilde[TildeBufferLength++] = LineBuffer[TildeLoop];
         } else {
End of Patch.

In case you are wondering: the munchconfig.exe that results from this cxx
compiler and cxxlink may not work too well, although tests are a bit
inconclusive owing to possible trouble with subconfigure.com and cxx
and ccflags et al.

At any rate with DEC C V6.0-001 and the above patch vmsperl
passes just as many tests as without.

Peter Prymmer




Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About