develooper Front page | perl.perl5.porters | Postings from April 2000

Re: [ID 20000403.009] uninitialised concatenation???

Thread Previous | Thread Next
From:
M.J.T. Guy
Date:
April 4, 2000 10:23
Subject:
Re: [ID 20000403.009] uninitialised concatenation???
Message ID:
E12cX2Y-000364-00@taurus.cus.cam.ac.uk
"Stephen P. Potter" <spp@spp.users.ds.net> wrote
> How about the much less inflamatory, and much more useful:
>
> --- opcode.h~   Tue Apr  4 09:30:06 2000
> +++ opcode.h    Tue Apr  4 09:26:38 2000

Not as useful as it might be  -  see the top of opcode.h:       :-)

/* !!!!!!!   DO NOT EDIT THIS FILE   !!!!!!!
   This file is built by opcode.pl from its data.  Any changes made here
   will be lost!
*/

And the tests need fixing.    Here's a second attempt.


Mike Guy

--- ./t/pragma/warn/op.orig	Tue Mar 21 05:10:54 2000
+++ ./t/pragma/warn/op	Tue Apr  4 17:45:36 2000
@@ -267,7 +267,7 @@
 Useless use of hash slice in void context at - line 30.
 Useless use of unpack in void context at - line 31.
 Useless use of pack in void context at - line 32.
-Useless use of join in void context at - line 33.
+Useless use of join or string in void context at - line 33.
 Useless use of list slice in void context at - line 34.
 Useless use of sort in void context at - line 37.
 Useless use of reverse in void context at - line 38.
--- ./t/pragma/warn/sv.orig	Tue Feb 22 08:55:14 2000
+++ ./t/pragma/warn/sv	Tue Apr  4 17:36:59 2000
@@ -178,7 +178,7 @@
 $C = "" ;
 $C .= $A ;
 EXPECT
-Use of uninitialized value in concatenation (.) at - line 10.
+Use of uninitialized value in concatenation (.) or string at - line 10.
 ########
 # sv.c 
 use warnings 'numeric' ;
--- ./opcode.pl.orig	Sun Mar 19 05:45:33 2000
+++ ./opcode.pl	Tue Apr  4 17:46:31 2000
@@ -434,7 +434,7 @@
 i_add		integer addition (+)	ck_null		ifsT2	S S
 subtract	subtraction (-)		ck_null		IfsT2	S S
 i_subtract	integer subtraction (-)	ck_null		ifsT2	S S
-concat		concatenation (.)	ck_concat	fsT2	S S
+concat		concatenation (.) or string	ck_concat	fsT2	S S
 stringify	string			ck_fun		fsT@	S
 
 left_shift	left bitshift (<<)	ck_bitop	fsT2	S S
@@ -533,7 +533,7 @@
 unpack		unpack			ck_fun		@	S S
 pack		pack			ck_fun		mst@	S L
 split		split			ck_split	t@	S S S
-join		join			ck_join		mst@	S L
+join		join or string		ck_join		mst@	S L
 
 # List operators.
 

End of patch

Thread Previous | Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About