develooper Front page | perl.perl5.porters | Postings from April 2000

ppport.h and polution (was: 5.6.0 ready for prime-time?)

Thread Previous | Thread Next
From:
Russ Allbery
Date:
April 3, 2000 15:18
Subject:
ppport.h and polution (was: 5.6.0 ready for prime-time?)
Message ID:
ylk8ie3k2p.fsf@windlord.stanford.edu
Gurusamy Sarathy <gsar@ActiveState.com> writes:
> On Mon, 03 Apr 2000 11:18:43 EDT, Norton Allen wrote:

>>  My module compiled without changes as late as .670, possibly with RC1,
>>  but required na => PL_na attention by RC2.

> I don't see anything about this in the archives.  Did you report it via
> perlbug?

Changes to #defines in patchlevel.h broke ppport.h, though; I wonder if
that has something to do with it.  That was our problem with INN at least.
I'm currently waiting on feedback on this patch from the person who
reported the problem with INN, or the time to install Perl 5.6.0 on a test
machine where I can build INN against it, but I think this patch against
1.0003 will fix the problem.

--- ppport.h.orig	Thu Feb 25 19:41:21 1999
+++ ppport.h	Mon Apr  3 15:16:48 2000
@@ -139,21 +139,25 @@
 */
 
 
-#ifndef PERL_PATCHLEVEL
+#if !defined(PERL_VERSION) && !defined(PERL_PATCHLEVEL)
 #	ifndef __PATCHLEVEL_H_INCLUDED__
 #		include "patchlevel.h"
 #	endif
 #endif
-#ifndef PERL_PATCHLEVEL
-#	define PERL_PATCHLEVEL PATCHLEVEL
-#	define PERL_SUBVERSION SUBVERSION
+#ifndef PERL_VERSION
+#	ifdef PERL_PATCHLEVEL
+#		define PERL_VERSION    PERL_PATCHLEVEL
+#	else
+#		define PERL_VERSION    PATCHLEVEL
+#		define PERL_SUBVERSION SUBVERSION
+#	endif
 #endif
 
 #ifndef ERRSV
 #	define ERRSV perl_get_sv("@",FALSE)
 #endif
 
-#if (PERL_PATCHLEVEL < 4) || ((PERL_PATCHLEVEL == 4) && (PERL_SUBVERSION <= 4))
+#if (PERL_VERSION < 4) || ((PERL_VERSION == 4) && (PERL_SUBVERSION <= 4))
 #	define PL_sv_undef	sv_undef
 #	define PL_sv_yes	sv_yes
 #	define PL_sv_no		sv_no
@@ -165,7 +169,7 @@
 #	define PL_copline	copline
 #endif
 
-#if (PERL_PATCHLEVEL < 5)
+#if (PERL_VERSION < 5)
 #  ifdef WIN32
 #	define dTHR extern int Perl___notused
 #  else
@@ -182,7 +186,7 @@
 /* Provide: newCONSTSUB */
 
 /* newCONSTSUB from IO.xs is in the core starting with 5.004_63 */
-#if (PATCHLEVEL < 4) || ((PATCHLEVEL == 4) && (SUBVERSION < 63))
+#if (PERL_VERSION < 4) || ((PERL_VERSION == 4) && (PERL_SUBVERSION < 63))
 
 /* Prototype */
 #if !defined(NEED_newCONSTSUB_GLOBAL)


-- 
Russ Allbery (rra@stanford.edu)             <http://www.eyrie.org/~eagle/>

Thread Previous | Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About