develooper Front page | perl.perl5.porters | Postings from November 1999

Re: Patch for Threading and Regexps

Thread Previous | Thread Next
From:
Ilya Zakharevich
Date:
November 29, 1999 16:12
Subject:
Re: Patch for Threading and Regexps
Message ID:
199911300012.TAA08165@monk.mps.ohio-state.edu
Brian Mancuso writes:
> +#ifdef USE_THREADS
> +
> +    r->regexp_index = number_of_regexps++;
> +
> +    /* If the thread compiling this regular expression doesn't
> +     * yet have space for its match variables, allocate space. */

This is a memory leak.  

> -    r->subbeg = NULL;
> +    get_match_node(r)->subbeg = NULL;

This should have been MATCH_DATA(r) (or somesuch).

Ilya
Thread Previous | Thread Next

nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About