develooper Front page | perl.perl5.porters | Postings from November 1999

Re: Patch for Threading and Regexps

Thread Previous | Thread Next
Rob Cunningham
November 19, 1999 16:27
Re: Patch for Threading and Regexps
Message ID:
Actually, your comments do not help.  If speed is not the only issue, then
could you explain why you think the patch is not sufficient? 

I have not looked at enough of perl's guts to be able to understand why you
think that this patch is broken--certainly not with a quick inspection. I do
know that in our testing this patch appears to fix the regexp/threads bug.
Please take the time to explain yourself, and if you have a suggested
alternative fix, then explain it well enough so that we can understand what
you think the issues are.


Ilya Zakharevich wrote:
> On Fri, Nov 19, 1999 at 07:10:09PM -0500, Rob Cunningham wrote:
> > I am amazed that people are arguing over whether to include the patch based on
> > the number of ops.  Threaded perl as currently distributed is broken in a way
> > that is fixed by this patch.
> Unamaze yourself.  There are more issues than just fixing bugs.
> A very cursory inspection shows that this patch is quite probably
> broken.  It may happen that this patch only hides the problem, not
> fixes it.
> In such a case all this patch will do is making it harder to fix the
> problem later.
> Hope this helps,
> Ilya

Dr. Robert K. Cunningham       Information System Technology Group                     MIT Lincoln Laboratory           
*** My comments, my opinions: my responsibility.
PGP key available from

Thread Previous | Thread Next Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at | Group listing | About