develooper Front page | perl.perl5.changes | Postings from November 2022

[Perl/perl5] 13bc0b: regcomp.c - correct comment

From:
Yves Orton via perl5-changes
Date:
November 9, 2022 14:32
Subject:
[Perl/perl5] 13bc0b: regcomp.c - correct comment
Message ID:
Perl/perl5/push/refs/heads/yves/parno_macro/000000-d9925b@github.com
  Branch: refs/heads/yves/parno_macro
  Home:   https://github.com/Perl/perl5
  Commit: 13bc0b402925e8482737be8cf08eef2268a3d58e
      https://github.com/Perl/perl5/commit/13bc0b402925e8482737be8cf08eef2268a3d58e
  Author: Yves Orton <demerphq@gmail.com>
  Date:   2022-11-09 (Wed, 09 Nov 2022)

  Changed paths:
    M regcomp.c

  Log Message:
  -----------
  regcomp.c - correct comment


  Commit: d9925b6d8cd83cac895cb51c31e3a3d64f5e42ab
      https://github.com/Perl/perl5/commit/d9925b6d8cd83cac895cb51c31e3a3d64f5e42ab
  Author: Yves Orton <demerphq@gmail.com>
  Date:   2022-11-09 (Wed, 09 Nov 2022)

  Changed paths:
    M regcomp.c
    M regcomp.h
    M regexec.c

  Log Message:
  -----------
  regcomp.c - add a PARNO() macro to wrap the ARG() macro

We used the ARG() macro to access the parno data for the OPNE
and CLOSE regops. This made it difficult to change the type and
size or location of this data in the node. Replacing this access
with a specific macro makes the code more legible and future proof.

This was actually backported from finding everything that broke
by changing the regnode type for OPEN and CLOSE to 2L and moving
the paren parameter to the 2L slot. We might do something like this
in the future and separating the PARNO() macros from their
implementation will make it easier.


Compare: https://github.com/Perl/perl5/compare/13bc0b402925%5E...d9925b6d8cd8



nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About