develooper Front page | perl.perl5.changes | Postings from August 2022

[Perl/perl5] 46bfb3: Configure should avoid looping infinitelyrepeatin...

From:
Nicholas Clark via perl5-changes
Date:
August 2, 2022 17:03
Subject:
[Perl/perl5] 46bfb3: Configure should avoid looping infinitelyrepeatin...
Message ID:
Perl/perl5/push/refs/heads/blead/6d02a9-46bfb3@github.com
  Branch: refs/heads/blead
  Home:   https://github.com/Perl/perl5
  Commit: 46bfb3c49f22629a21d99ff2d02461a2a8a9aac4
      https://github.com/Perl/perl5/commit/46bfb3c49f22629a21d99ff2d02461a2a8a9aac4
  Author: Nicholas Clark <nick@ccl4.org>
  Date:   2022-08-02 (Tue, 02 Aug 2022)

  Changed paths:
    M Configure

  Log Message:
  -----------
  Configure should avoid looping infinitely repeating the same question

Configure's helper function ./myread is intended to loop until it gets an
acceptable answer. For a couple of cases, an empty string is not acceptable
(eg 'Where is your C library?', if all automated attempts at answering this
have failed). In these cases, if Configure's standard input is /dev/null (or
closed), the shell read returns an empty string, and ./myread repeats the
question.

Before this commit, it would loop infinitely (generating continuous terminal
output). With this commit, we add a retry counter - if it asks the same
question to many times, it aborts Configure. This means that unattended
./Configure runs should now always terminate, as termination with an error
is better than spinning forever.





nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About