develooper Front page | perl.perl5.changes | Postings from August 2022

[Perl/perl5] ac083d: File::Find: "follow" and "follow_fast" aren'tno-o...

From:
"A. Sinan Unur" via perl5-changes
Date:
August 2, 2022 00:20
Subject:
[Perl/perl5] ac083d: File::Find: "follow" and "follow_fast" aren'tno-o...
Message ID:
Perl/perl5/push/refs/heads/blead/86a06d-414f14@github.com
  Branch: refs/heads/blead
  Home:   https://github.com/Perl/perl5
  Commit: ac083dce6a86105e47992498ab05965aae99496b
      https://github.com/Perl/perl5/commit/ac083dce6a86105e47992498ab05965aae99496b
  Author: Tomasz Konojacki <me@xenu.pl>
  Date:   2022-08-02 (Tue, 02 Aug 2022)

  Changed paths:
    M ext/File-Find/lib/File/Find.pm

  Log Message:
  -----------
  File::Find: "follow" and "follow_fast" aren't no-ops on Win32

Not since 0d00729c03a1f68e1b51e986d1ce9000b0e3d301.


  Commit: 2fcaad36c709e83c97f2f0995f00b46abcd4c24c
      https://github.com/Perl/perl5/commit/2fcaad36c709e83c97f2f0995f00b46abcd4c24c
  Author: Tomasz Konojacki <me@xenu.pl>
  Date:   2022-08-02 (Tue, 02 Aug 2022)

  Changed paths:
    M ext/File-Find/lib/File/Find.pm
    M ext/File-Find/t/lib/Testing.pm
    M ext/File-Find/t/taint.t

  Log Message:
  -----------
  File::Find: normalise indentation

This commit doesn't contain any functional changes. If you're
seeing it in "git blame" output, try using -w switch, it will
hide whitespace-only changes.


  Commit: 414f14df98cb1c9a20f92c5c54948b67c09f072d
      https://github.com/Perl/perl5/commit/414f14df98cb1c9a20f92c5c54948b67c09f072d
  Author: A. Sinan Unur <sinan@unur.com>
  Date:   2022-08-02 (Tue, 02 Aug 2022)

  Changed paths:
    M MANIFEST
    M Porting/Maintainers.pl
    M cpan/AutoLoader/t/02AutoSplit.t
    M ext/File-Find/lib/File/Find.pm
    A ext/File-Find/t/correct-absolute-path-with-follow.t
    M ext/File-Find/t/find.t
    M t/porting/customized.dat

  Log Message:
  -----------
  File::Find: fix "follow => 1" on Windows

File::Find's code expects unix-style paths and it manipulates them using
basic string operations. That code is very fragile, and ideally we
should make it use File::Spec, but that would involve rewriting almost
the whole module.

Instead, we made it convert backslashes to slashes and handle drive
letters.

Note from xenu: this commit was adapted from the PR linked in this
blogpost[1]. I have squashed it, written the commit message and slightly
modified the code.

[1] - https://www.nu42.com/2021/09/canonical-paths-file-find-way-forward.html

Fixes #19995


Compare: https://github.com/Perl/perl5/compare/86a06db9fa5d...414f14df98cb



nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About