develooper Front page | perl.perl5.changes | Postings from October 2021

[Perl/perl5] f73a32: In manicheck be explicit that the code isstrippin...

From:
Nicholas Clark via perl5-changes
Date:
October 12, 2021 10:17
Subject:
[Perl/perl5] f73a32: In manicheck be explicit that the code isstrippin...
Message ID:
Perl/perl5/push/refs/heads/blead/09cd3e-08ab26@github.com
  Branch: refs/heads/blead
  Home:   https://github.com/Perl/perl5
  Commit: f73a32e0fd37de0a9c1965edfc1bda20d38e12d7
      https://github.com/Perl/perl5/commit/f73a32e0fd37de0a9c1965edfc1bda20d38e12d7
  Author: Nicholas Clark <nick@ccl4.org>
  Date:   2021-10-12 (Tue, 12 Oct 2021)

  Changed paths:
    M Porting/manicheck

  Log Message:
  -----------
  In manicheck be explicit that the code is stripping './'

The regex had been written as /^../, which strictly was correct as the
string passed would *always* start with './', but this wasn't clear.

One had to stop and double check how File::Find::find() works, and what
argument it was called with. And it's not exactly clear when the '.' in
the regex text matches '.' and then '/', but the '/' in the regex is the
delimiter.

Given that the regex is being changed, move it later - previously the code
was performing a substitution on the value of $File::Find::name before it
knew that it needed it. (ie doing work for all directories.)


  Commit: a36da35bfcd30972d735b109216c89367a655e9b
      https://github.com/Perl/perl5/commit/a36da35bfcd30972d735b109216c89367a655e9b
  Author: Nicholas Clark <nick@ccl4.org>
  Date:   2021-10-12 (Tue, 12 Oct 2021)

  Changed paths:
    M Porting/manicheck

  Log Message:
  -----------
  manicheck now optionally exits non-zero if it finds problems

This will enable it to be used in a CI test.

Refactor the code to avoid the temporary array @files by iterating over the
lines of MANIFEST as they are read in.


  Commit: 551ba941f1431c20d6f393b3fbd1f017ca7e58b9
      https://github.com/Perl/perl5/commit/551ba941f1431c20d6f393b3fbd1f017ca7e58b9
  Author: Nicholas Clark <nick@ccl4.org>
  Date:   2021-10-12 (Tue, 12 Oct 2021)

  Changed paths:
    M .github/workflows/testsuite.yml

  Log Message:
  -----------
  Add CI tests for `make distclean` and Porting/manicheck


  Commit: 0ffd62ab6d6ea5269e08445494bf624decf410f6
      https://github.com/Perl/perl5/commit/0ffd62ab6d6ea5269e08445494bf624decf410f6
  Author: Nicholas Clark <nick@ccl4.org>
  Date:   2021-10-12 (Tue, 12 Oct 2021)

  Changed paths:
    M .github/workflows/testsuite.yml

  Log Message:
  -----------
  A CI test that manicheck has no errors after `git clean -dxf`


  Commit: 432caf78e5762ca90de95d1c339b9bec45693cfc
      https://github.com/Perl/perl5/commit/432caf78e5762ca90de95d1c339b9bec45693cfc
  Author: Nicholas Clark <nick@ccl4.org>
  Date:   2021-10-12 (Tue, 12 Oct 2021)

  Changed paths:
    M .github/workflows/testsuite.yml

  Log Message:
  -----------
  A CI test that manicheck reports no errors on a clean checkout

Do this on the "minitest" job as that has no "manicheck" step yet, and the
"minitest" job does not have a "matrix", so we only run this actual test
once.


  Commit: 08ab26ef89ca13edb987769d77fd62e4c0aef2d0
      https://github.com/Perl/perl5/commit/08ab26ef89ca13edb987769d77fd62e4c0aef2d0
  Author: Nicholas Clark <nick@ccl4.org>
  Date:   2021-10-12 (Tue, 12 Oct 2021)

  Changed paths:
    M .github/workflows/testsuite.yml

  Log Message:
  -----------
  Leave the checkout `fetch-depth` at its default (1) for most jobs

The default is a shallow checkout.

Keep the full checkout for the "sanity test" job so that it runs all the
tests in t/porting. Add a comment explaining the reasoning.


Compare: https://github.com/Perl/perl5/compare/09cd3e1cbb58...08ab26ef89ca



nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About