develooper Front page | perl.perl5.changes | Postings from February 2021

[Perl/perl5] 30fd84: hv_func.h: Move static declaration so it workswit...

From:
Yves Orton via perl5-changes
Date:
February 12, 2021 14:59
Subject:
[Perl/perl5] 30fd84: hv_func.h: Move static declaration so it workswit...
Message ID:
Perl/perl5/push/refs/heads/smoke-me/yves_hash_and_build_fixes/4e5069-64c21b@github.com
  Branch: refs/heads/smoke-me/yves_hash_and_build_fixes
  Home:   https://github.com/Perl/perl5
  Commit: 30fd840679baa3b72a96233e94b0f3e45e6ed97e
      https://github.com/Perl/perl5/commit/30fd840679baa3b72a96233e94b0f3e45e6ed97e
  Author: Yves Orton <demerphq@gmail.com>
  Date:   2021-02-12 (Fri, 12 Feb 2021)

  Changed paths:
    M hv_func.h

  Log Message:
  -----------
  hv_func.h: Move static declaration so it works with Siphash builds


  Commit: 746d9f6444969446902a3b15e1d247d7d64c8190
      https://github.com/Perl/perl5/commit/746d9f6444969446902a3b15e1d247d7d64c8190
  Author: Yves Orton <demerphq@gmail.com>
  Date:   2021-02-12 (Fri, 12 Feb 2021)

  Changed paths:
    M hv.c

  Log Message:
  -----------
  hv.c: add a guard clause to prevent the number of buckets in a hash from getting too large

This caps it at 1<<28 buckets, eg, ~268M. In theory without a guard clause like
this we could grow to the point of possibly wrapping around in terms of size,
not to mention being ridiculously wasteful of memory at larger sizes.
Even this cap is probably too high. It should probably be something like 1<<24.


  Commit: 0b46c450ea5ea4d2d865868a46a1179063b42761
      https://github.com/Perl/perl5/commit/0b46c450ea5ea4d2d865868a46a1179063b42761
  Author: Yves Orton <demerphq@gmail.com>
  Date:   2021-02-12 (Fri, 12 Feb 2021)

  Changed paths:
    M hv_func.h

  Log Message:
  -----------
  [#18555] hv_func.h - Ensure that hash related data is properly aligned

Andrew Fresh reported that the data being unaligned causes issues and
performance degredation under some or all builds. This is an enhacement
of his original patch to handle the 32 bit case, and to make some
related magic numbers more obvious.


  Commit: f4bdda7dbb46c025ff9e5e4a1c9649bf8befdf73
      https://github.com/Perl/perl5/commit/f4bdda7dbb46c025ff9e5e4a1c9649bf8befdf73
  Author: Yves Orton <demerphq@gmail.com>
  Date:   2021-02-12 (Fri, 12 Feb 2021)

  Changed paths:
    M ext/Hash-Util/Changes
    M ext/Hash-Util/Util.xs
    M ext/Hash-Util/lib/Hash/Util.pm
    M ext/Hash-Util/t/Util.t

  Log Message:
  -----------
  Hash::Util - Add tests for hash_value($str,$seed) which was broken for a while

Also tweak a sprintf not to warn. This bumps the version to 0.25 and
adds missing (and uniniteresting) Changes file.


  Commit: f508123ffe984ed4ce0ba0110283854227b44fa6
      https://github.com/Perl/perl5/commit/f508123ffe984ed4ce0ba0110283854227b44fa6
  Author: Yves Orton <demerphq@gmail.com>
  Date:   2021-02-12 (Fri, 12 Feb 2021)

  Changed paths:
    M t/opbasic/arith.t

  Log Message:
  -----------
  opbasic/arith.t - make sure we use the right Config

We were warning about only using Config::Config once. Digging it seems
that the Config module is only loaded under VMS, and the checks on $Config{foo}
were checking an empty hash. This changes them to use $Config::Config{foo} so
that we use the right hash when Config.pm is required in the VMS code


  Commit: 482a0dbdb1a5608fae331f43b4efbc31d7a455a9
      https://github.com/Perl/perl5/commit/482a0dbdb1a5608fae331f43b4efbc31d7a455a9
  Author: Yves Orton <demerphq@gmail.com>
  Date:   2021-02-12 (Fri, 12 Feb 2021)

  Changed paths:
    M ext/PerlIO-encoding/encoding.pm
    M ext/PerlIO-encoding/encoding.xs

  Log Message:
  -----------
  PerlIO-encoding - add parens to silence build warnings


  Commit: 64c21bb75cd236aa749d0c687a36e56008973e7b
      https://github.com/Perl/perl5/commit/64c21bb75cd236aa749d0c687a36e56008973e7b
  Author: Yves Orton <demerphq@gmail.com>
  Date:   2021-02-12 (Fri, 12 Feb 2021)

  Changed paths:
    M ext/PerlIO-encoding/encoding.xs

  Log Message:
  -----------
  encoding.xs - silence unused var warnings

in 370c6ab2e9608a94096854c61d976ccf65bb2c13 logic to set PerlIO::encoding::fallback in
encoding.xs was removed, but this var was missed in the cleanup.


Compare: https://github.com/Perl/perl5/compare/4e5069b60ae5...64c21bb75cd2



nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About