develooper Front page | perl.perl5.changes | Postings from February 2021

[Perl/perl5] 7ecd57: hv_func.h: Move static declaration so it workswit...

Thread Previous
From:
Yves Orton via perl5-changes
Date:
February 12, 2021 12:23
Subject:
[Perl/perl5] 7ecd57: hv_func.h: Move static declaration so it workswit...
Message ID:
Perl/perl5/push/refs/heads/smoke-me/yves_hash_and_build_fixes/000000-131864@github.com
  Branch: refs/heads/smoke-me/yves_hash_and_build_fixes
  Home:   https://github.com/Perl/perl5
  Commit: 7ecd571465fad1de4f84ef24836c1612dac6a530
      https://github.com/Perl/perl5/commit/7ecd571465fad1de4f84ef24836c1612dac6a530
  Author: Yves Orton <demerphq@gmail.com>
  Date:   2021-02-12 (Fri, 12 Feb 2021)

  Changed paths:
    M hv_func.h

  Log Message:
  -----------
  hv_func.h: Move static declaration so it works with Siphash builds


  Commit: 3fac72d1232fda0a8d57ec8b890a5567b6327024
      https://github.com/Perl/perl5/commit/3fac72d1232fda0a8d57ec8b890a5567b6327024
  Author: Yves Orton <demerphq@gmail.com>
  Date:   2021-02-12 (Fri, 12 Feb 2021)

  Changed paths:
    M hv.c

  Log Message:
  -----------
  hv.c: add a guard clause to prevent the number of buckets in a hash from getting too large

This caps it at 1<<28 buckets, eg, ~268M. In theory without a guard clause like
this we could grow to the point of possibly wrapping around in terms of size,
not to mention being ridiculously wasteful of memory at larger sizes.
Even this cap is probably too high. It should probably be something like 1<<24.


  Commit: 99922edd6efbb4dc3e922ed2fc72d0748d575c29
      https://github.com/Perl/perl5/commit/99922edd6efbb4dc3e922ed2fc72d0748d575c29
  Author: Yves Orton <demerphq@gmail.com>
  Date:   2021-02-12 (Fri, 12 Feb 2021)

  Changed paths:
    M hv_func.h

  Log Message:
  -----------
  [#18555] hv_func.h - Ensure that hash related data is properly aligned

Andrew Fresh reported that the data being unaligned causes issues and
performance degredation under some or all builds. This is an enhacement
of his original patch to handle the 32 bit case, and to make some
related magic numbers more obvious.


  Commit: 44c4e600092db1cee22c7867d94fefb7fe134132
      https://github.com/Perl/perl5/commit/44c4e600092db1cee22c7867d94fefb7fe134132
  Author: Yves Orton <demerphq@gmail.com>
  Date:   2021-02-12 (Fri, 12 Feb 2021)

  Changed paths:
    M hv_func.h

  Log Message:
  -----------
  hv_func.h - provide the function that PERL_HASH_WITH_SEED() resolves to

The internals use PERL_HASH_WITH_STATE(), but we offer the
PERL_HASH_WITH_SEED() also so we should actually define it.


  Commit: a6a53301f9062287308c88c3580eb1ed967a0fdc
      https://github.com/Perl/perl5/commit/a6a53301f9062287308c88c3580eb1ed967a0fdc
  Author: Yves Orton <demerphq@gmail.com>
  Date:   2021-02-12 (Fri, 12 Feb 2021)

  Changed paths:
    M ext/Hash-Util/Changes
    M ext/Hash-Util/Util.xs
    M ext/Hash-Util/lib/Hash/Util.pm
    M ext/Hash-Util/t/Util.t

  Log Message:
  -----------
  Hash::Util - Add tests for hash_value($str,$seed) which was broken for a while

Also tweak a sprintf not to warn. This bumps the version to 0.25 and
adds missing (and uniniteresting) Changes file.


  Commit: 32f2f9633a6a3d2c64362b3a4981f4bb473427fe
      https://github.com/Perl/perl5/commit/32f2f9633a6a3d2c64362b3a4981f4bb473427fe
  Author: Yves Orton <demerphq@gmail.com>
  Date:   2021-02-12 (Fri, 12 Feb 2021)

  Changed paths:
    M t/opbasic/arith.t

  Log Message:
  -----------
  opbasic/arith.t - make sure we use the right Config

We were warning about only using Config::Config once. Digging it seems
that the Config module is only loaded under VMS, and the checks on $Config{foo}
were checking an empty hash. This changes them to use $Config::Config{foo} so
that we use the right hash when Config.pm is required in the VMS code


  Commit: 9aa700d43e26927edbfdc8329f29b089573237c9
      https://github.com/Perl/perl5/commit/9aa700d43e26927edbfdc8329f29b089573237c9
  Author: Yves Orton <demerphq@gmail.com>
  Date:   2021-02-12 (Fri, 12 Feb 2021)

  Changed paths:
    M ext/PerlIO-encoding/encoding.pm
    M ext/PerlIO-encoding/encoding.xs

  Log Message:
  -----------
  PerlIO-encoding - add parens to silence build warnings


  Commit: 1318644a8297d19d26df264b66ef8a0e2f31648c
      https://github.com/Perl/perl5/commit/1318644a8297d19d26df264b66ef8a0e2f31648c
  Author: Yves Orton <demerphq@gmail.com>
  Date:   2021-02-12 (Fri, 12 Feb 2021)

  Changed paths:
    M ext/PerlIO-encoding/encoding.xs

  Log Message:
  -----------
  encoding.xs - silence unused var warnings

in 370c6ab2e9608a94096854c61d976ccf65bb2c13 logic to set PerlIO::encoding::fallback in
encoding.xs was removed, but the var was still created presumably to ensure that var is
created in the global namespace early. But this means we get unused var warnings,
so this code adds a simple check to silence them.


Compare: https://github.com/Perl/perl5/compare/7ecd571465fa%5E...1318644a8297

Thread Previous


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About