develooper Front page | perl.perl5.changes | Postings from May 2020

[Perl/perl5] 439a14: regcomp.c: Extract code from atoo-large-function

From:
Karl Williamson
Date:
May 26, 2020 17:22
Subject:
[Perl/perl5] 439a14: regcomp.c: Extract code from atoo-large-function
Message ID:
Perl/perl5/push/refs/heads/smoke-me/khw-bitmap/31b773-d599b8@github.com
  Branch: refs/heads/smoke-me/khw-bitmap
  Home:   https://github.com/Perl/perl5
  Commit: 439a14808e9b82c4e5a72cc406bb84f44659a4c4
      https://github.com/Perl/perl5/commit/439a14808e9b82c4e5a72cc406bb84f44659a4c4
  Author: Karl Williamson <khw@cpan.org>
  Date:   2020-05-26 (Tue, 26 May 2020)

  Changed paths:
    M embed.fnc
    M embed.h
    M proto.h
    M regcomp.c

  Log Message:
  -----------
  regcomp.c: Extract code from a too-large-function

S_regclass() is unwieldy.  This commit splits it into two nearly equal
size parts.  More could be done.


  Commit: e205aec26382db2907b4968d033714215737c20c
      https://github.com/Perl/perl5/commit/e205aec26382db2907b4968d033714215737c20c
  Author: Karl Williamson <khw@cpan.org>
  Date:   2020-05-26 (Tue, 26 May 2020)

  Changed paths:
    M regcomp.c

  Log Message:
  -----------
  regcomp.c: Almost all white-space; one paren pair added

The parens are for clarity in an expression.


  Commit: 4e3622111d0b5b6802a435fc1aa8ec03694901a0
      https://github.com/Perl/perl5/commit/4e3622111d0b5b6802a435fc1aa8ec03694901a0
  Author: Karl Williamson <khw@cpan.org>
  Date:   2020-05-26 (Tue, 26 May 2020)

  Changed paths:
    M regcomp.c

  Log Message:
  -----------
  regcomp.c: Consolidate duplicate code


  Commit: 5d0aea32a758bc8f74ce76be2ce896da6cb0d326
      https://github.com/Perl/perl5/commit/5d0aea32a758bc8f74ce76be2ce896da6cb0d326
  Author: Karl Williamson <khw@cpan.org>
  Date:   2020-05-26 (Tue, 26 May 2020)

  Changed paths:
    M regcomp.c

  Log Message:
  -----------
  regcomp.c: Move some code to within a block

This code is irrelevant unless the condition of the block immediately
before it is TRUE, so move it to within that block.


  Commit: f0330284c6a692798f1441dd822554e1067d1c4a
      https://github.com/Perl/perl5/commit/f0330284c6a692798f1441dd822554e1067d1c4a
  Author: Karl Williamson <khw@cpan.org>
  Date:   2020-05-26 (Tue, 26 May 2020)

  Changed paths:
    M regcomp.c

  Log Message:
  -----------
  regcomp.c: White-space only

Indent code now in a new block


  Commit: 961c098b0bca2c182691a4b1b457aab40ce9d529
      https://github.com/Perl/perl5/commit/961c098b0bca2c182691a4b1b457aab40ce9d529
  Author: Karl Williamson <khw@cpan.org>
  Date:   2020-05-26 (Tue, 26 May 2020)

  Changed paths:
    M regcomp.c

  Log Message:
  -----------
  regcomp.c: Add a clearer mnemonic


  Commit: 17cf6ee494680fe48a889683f6ef852e5c4e90d2
      https://github.com/Perl/perl5/commit/17cf6ee494680fe48a889683f6ef852e5c4e90d2
  Author: Karl Williamson <khw@cpan.org>
  Date:   2020-05-26 (Tue, 26 May 2020)

  Changed paths:
    M regcomp.c

  Log Message:
  -----------
  regcomp.c: Save a value instead of re-calling fcn

This variable will be used in future commits in more places, so compute
it just once.


  Commit: 50ba7d668f02ef43a855db7219c56beb82659660
      https://github.com/Perl/perl5/commit/50ba7d668f02ef43a855db7219c56beb82659660
  Author: Karl Williamson <khw@cpan.org>
  Date:   2020-05-26 (Tue, 26 May 2020)

  Changed paths:
    M pod/perldebguts.pod
    M regcomp.sym
    M regnodes.h

  Log Message:
  -----------
  XXX flesh out: regcomp.sym: Add POSIXA1R node


  Commit: 4d08b1b765f24eb61c80d805b126341835122336
      https://github.com/Perl/perl5/commit/4d08b1b765f24eb61c80d805b126341835122336
  Author: Karl Williamson <khw@cpan.org>
  Date:   2020-05-26 (Tue, 26 May 2020)

  Changed paths:
    M regcomp.c
    M regcomp.h
    M regexec.c

  Log Message:
  -----------
  Use POSIXA1R


  Commit: b65ea9859cdabd8152796ed2776013df58b3e6ff
      https://github.com/Perl/perl5/commit/b65ea9859cdabd8152796ed2776013df58b3e6ff
  Author: Karl Williamson <khw@cpan.org>
  Date:   2020-05-26 (Tue, 26 May 2020)

  Changed paths:
    M Porting/bench.pl

  Log Message:
  -----------
  XXX don't push, khw customization for bench.pl


  Commit: d599b8d2372326fd984d10a6be0771733ffbcc2d
      https://github.com/Perl/perl5/commit/d599b8d2372326fd984d10a6be0771733ffbcc2d
  Author: Karl Williamson <khw@cpan.org>
  Date:   2020-05-26 (Tue, 26 May 2020)

  Changed paths:
    M regcomp.c
    M regcomp.h

  Log Message:
  -----------
  XXX restrict to digit


Compare: https://github.com/Perl/perl5/compare/31b7730c1ab3...d599b8d23723



nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About