develooper Front page | perl.perl5.changes | Postings from May 2020

[Perl/perl5] 7db9f5: regen/regcomp.pl: Extract repeated format to ascalar

From:
Karl Williamson
Date:
May 7, 2020 05:10
Subject:
[Perl/perl5] 7db9f5: regen/regcomp.pl: Extract repeated format to ascalar
Message ID:
Perl/perl5/push/refs/heads/smoke-me/khw-case/000000-68edde@github.com
  Branch: refs/heads/smoke-me/khw-case
  Home:   https://github.com/Perl/perl5
  Commit: 7db9f5443bc328e35c11331b5a2ae64a169da207
      https://github.com/Perl/perl5/commit/7db9f5443bc328e35c11331b5a2ae64a169da207
  Author: Karl Williamson <khw@cpan.org>
  Date:   2020-05-06 (Wed, 06 May 2020)

  Changed paths:
    M regen/regcomp.pl

  Log Message:
  -----------
  regen/regcomp.pl: Extract repeated format to a scalar

So if change, only have to change it once.


  Commit: 65e0acfedd38473b95c45cfcdc38100b4079818d
      https://github.com/Perl/perl5/commit/65e0acfedd38473b95c45cfcdc38100b4079818d
  Author: Karl Williamson <khw@cpan.org>
  Date:   2020-05-06 (Wed, 06 May 2020)

  Changed paths:
    M cpan/Test-Harness/lib/App/Prove.pm
    M cpan/Test-Harness/lib/App/Prove/State.pm
    M cpan/Test-Harness/lib/App/Prove/State/Result.pm
    M cpan/Test-Harness/lib/App/Prove/State/Result/Test.pm
    M cpan/Test-Harness/lib/TAP/Base.pm
    M cpan/Test-Harness/lib/TAP/Formatter/Base.pm
    M cpan/Test-Harness/lib/TAP/Formatter/Color.pm
    M cpan/Test-Harness/lib/TAP/Formatter/Console.pm
    M cpan/Test-Harness/lib/TAP/Formatter/Console/ParallelSession.pm
    M cpan/Test-Harness/lib/TAP/Formatter/Console/Session.pm
    M cpan/Test-Harness/lib/TAP/Formatter/File.pm
    M cpan/Test-Harness/lib/TAP/Formatter/File/Session.pm
    M cpan/Test-Harness/lib/TAP/Formatter/Session.pm
    M cpan/Test-Harness/lib/TAP/Harness.pm
    M cpan/Test-Harness/lib/TAP/Harness/Env.pm
    M cpan/Test-Harness/lib/TAP/Object.pm
    M cpan/Test-Harness/lib/TAP/Parser.pm
    M cpan/Test-Harness/lib/TAP/Parser/Aggregator.pm
    M cpan/Test-Harness/lib/TAP/Parser/Grammar.pm
    M cpan/Test-Harness/lib/TAP/Parser/Iterator.pm
    M cpan/Test-Harness/lib/TAP/Parser/Iterator/Array.pm
    M cpan/Test-Harness/lib/TAP/Parser/Iterator/Process.pm
    M cpan/Test-Harness/lib/TAP/Parser/Iterator/Stream.pm
    M cpan/Test-Harness/lib/TAP/Parser/IteratorFactory.pm
    M cpan/Test-Harness/lib/TAP/Parser/Multiplexer.pm
    M cpan/Test-Harness/lib/TAP/Parser/Result.pm
    M cpan/Test-Harness/lib/TAP/Parser/Result/Bailout.pm
    M cpan/Test-Harness/lib/TAP/Parser/Result/Comment.pm
    M cpan/Test-Harness/lib/TAP/Parser/Result/Plan.pm
    M cpan/Test-Harness/lib/TAP/Parser/Result/Pragma.pm
    M cpan/Test-Harness/lib/TAP/Parser/Result/Test.pm
    M cpan/Test-Harness/lib/TAP/Parser/Result/Unknown.pm
    M cpan/Test-Harness/lib/TAP/Parser/Result/Version.pm
    M cpan/Test-Harness/lib/TAP/Parser/Result/YAML.pm
    M cpan/Test-Harness/lib/TAP/Parser/ResultFactory.pm
    M cpan/Test-Harness/lib/TAP/Parser/Scheduler.pm
    M cpan/Test-Harness/lib/TAP/Parser/Scheduler/Job.pm
    M cpan/Test-Harness/lib/TAP/Parser/Scheduler/Spinner.pm
    M cpan/Test-Harness/lib/TAP/Parser/Source.pm
    M cpan/Test-Harness/lib/TAP/Parser/SourceHandler.pm
    M cpan/Test-Harness/lib/TAP/Parser/SourceHandler/Executable.pm
    M cpan/Test-Harness/lib/TAP/Parser/SourceHandler/File.pm
    M cpan/Test-Harness/lib/TAP/Parser/SourceHandler/Handle.pm
    M cpan/Test-Harness/lib/TAP/Parser/SourceHandler/Perl.pm
    M cpan/Test-Harness/lib/TAP/Parser/SourceHandler/RawTAP.pm
    M cpan/Test-Harness/lib/TAP/Parser/YAMLish/Reader.pm
    M cpan/Test-Harness/lib/TAP/Parser/YAMLish/Writer.pm
    M cpan/Test-Harness/lib/Test/Harness.pm

  Log Message:
  -----------
  TAP::Harness: Move timer initialization

Prior to this commit, the timers for counting elapsed time and CPU usage
were begun when a job's first output appears.  This yields inaccurate
results.  These results are saved in t/test_state for future runs so
that they can start the longest-running tests first, which leads to
using the available cores more efficiently.  (If you start a long running
test after everything else is nearly done, you have to wait for it to
finish before the suite as a whole is; if you start the long ones first,
and the shortest last, you don't have to wait very long for any
stragglers to complete.)  Inaccurate results here lead to this
situation, which we were often seeing in the podcheck.t test.

The worst case is if there is heavy computation at the beginning of the
test being run.  podcheck, for example, examines all the pods in the
directory structure to find which links to other pods do or do not have
corresponding anchors.  Output doesn't happen until the analysis is
complete.  On my system, this takes over 30 seconds, but prior to this
commit, what was noted was just the time required to do the output,
about 200 milliseconds.  The result was that podcheck was viewed as
being one of the shortest tests run, so was started late in the process,
and generally held up the completion of it.

This commit by itself doesn't improve the test completion very much,
because, test tests are run a whole directory at a time, and the
directory podcheck is in, for example, is run last.  The next commit
addresses that.


  Commit: 1c3b7189fdaa7da95eef88217c043afe94ac454e
      https://github.com/Perl/perl5/commit/1c3b7189fdaa7da95eef88217c043afe94ac454e
  Author: Karl Williamson <khw@cpan.org>
  Date:   2020-05-06 (Wed, 06 May 2020)

  Changed paths:
    M t/harness

  Log Message:
  -----------
  XXX env name: t/harness: Add option for faster test suite execution

This commit adds an environment variable, XXX, which if set to non-zero
increases the parallelism in the execution of the test suite, speeding
it up on systems with multiple cores.

Normally, there are two main test sections, one for core and the second
for non-core tests, and the testing of the non-core one doesn't begin
until the first is complete.  Within each section, there are a number of
test categories, like 're' for regular expressions, and 'JSON::PP' for
the pure perl implementation of JSON.

Within each category, there are various single .t test files.  Some
categories can have those be tested in parallel; some require them to be
done in a particular order, say because an earlier .t does setup for
subsequent ones.  We already have this capability.

Completion of all the tests in a category is not needed before those of
another category can be started.  This is how it already works.

However, the core section categories are ordered so that they begin in a
logical order for someone trying to get perl to work.  First to start
are the basic sanity tests, then by roughly decreasing order of
widespread use in perl programs in the wild, with the final two
categories, porting and perf, being mainly of use to perl5 porters.
These two categories aren't started until all the tests in the earlier
categories are started.  We have some long running tests in those two
categories, and generally they delay the start of the entire second section.

If those long running tests could be started sooner, shorter tests in
the first section could be run in parallel with them, increasing the
average CPU utilization, and the second section could begin (and hence
end) earlier, shortening the total elapsed execution time of the entire
suite.

The second section has some very long running tests.  JSON-PP is one of
them.  If it could run in parallel with tests from the first section,
that would also speed up the completion of the suite.

The environment variable added by this commit does both things.  The
basic sanity test categories in the first section continue to be started
before anything else.  But then all other tests are run in decreasing
order of elapsed time they take to run, removing the boundaries between
some categories, and between the two sections.

The gain from this increases as the number of jobs run in parallel does;
slower high core platforms have the highest increase.  On the old
dromedary with 24 cores, the gain is 20%, almost 2 minutes.  On my more
modern box with 12 cores, it is 8%.


  Commit: 18371954314adddc52ded757a40924067b6d0585
      https://github.com/Perl/perl5/commit/18371954314adddc52ded757a40924067b6d0585
  Author: Karl Williamson <khw@cpan.org>
  Date:   2020-05-06 (Wed, 06 May 2020)

  Changed paths:
    M regen/regcomp.pl
    M regnodes.h

  Log Message:
  -----------
  regen/regcomp.pl: Generate #defines for UTF8ness

This causes #defines to be generated for regexec.c to use in switch
statements, so that for each opcode there can be a case: for the target
being UTF-8, and another for it not.

This will be used in future commits to simplify things.


  Commit: ce93c329cb4b91764f385733ee545183edbddd19
      https://github.com/Perl/perl5/commit/ce93c329cb4b91764f385733ee545183edbddd19
  Author: Karl Williamson <khw@cpan.org>
  Date:   2020-05-06 (Wed, 06 May 2020)

  Changed paths:
    M regexec.c

  Log Message:
  -----------
  regexec.c: regrepeat: Separate each op into UTF-8 or not

Many of the ops have different code for when the target string being
matched is encoded in UTF-8 vs when it isn't.  Instead of doing a test
for this in each op, incorporate that knowledge into the switch
statement, so that there is a non-UTF-8 case, and a UTF-8 case for each
op.

This commit starts the process, leaving some consolidation to the next
commit, and white space reconciliation as a result of the removal of
blocks to an even later commit.

The EXACTish nodes are not changed by this commit, in part because I
have WIP that changes them anyway.


  Commit: 68eddee24e1374850710c2b8c482e5e5b4eb7c6e
      https://github.com/Perl/perl5/commit/68eddee24e1374850710c2b8c482e5e5b4eb7c6e
  Author: Karl Williamson <khw@cpan.org>
  Date:   2020-05-06 (Wed, 06 May 2020)

  Changed paths:
    M regexec.c

  Log Message:
  -----------
  regexec.c: Rearrange some case: statements

This can get rid of some goto's and extra break statements.


Compare: https://github.com/Perl/perl5/compare/7db9f5443bc3%5E...68eddee24e13



nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About