develooper Front page | perl.perl5.changes | Postings from March 2018

[perl.git] branch blead updated. v5.27.8-417-g4ac5f10b75

Tony Cook
March 1, 2018 03:33
[perl.git] branch blead updated. v5.27.8-417-g4ac5f10b75
Message ID:
In perl.git, the branch blead has been updated


- Log -----------------------------------------------------------------
commit 4ac5f10b7537a9008856dd6cd7a9fd94e0dffc32
Author: Daniel Dragan <>
Date:   Wed Feb 28 19:42:19 2018 -0500

    regen/ close FH before unlink
    On Win32, failed if something caused different checksum for
    perldebguts.pod and the old file was attempted to be unlinked/renamed, but
    that was failing because the FH is still open (Win32 specific thing).
    So close the FH before renaming the file instead of having scope exit close
    the FH after close_and_rename() executes.
    the fixed error console log:
    changed 'pod/perldebguts.pod-new' to 'pod/perldebguts.pod'
    Couldn't unlink pod/perldebguts.pod: Permission denied
    renaming pod/perldebguts.pod-new to pod/perldebguts.pod: Permission denied at ./
    regen/ line 120, <$oldguts> line 1046.
    Changed: pod/perldebguts.pod
    C:\perl\bin\perl.exe -I. regen/ -v failed: 3328 at line 20, <
    DATA> line 8.


Summary of changes:
 regen/ | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/regen/ b/regen/
index 88c0ac9b81..ffb7d7a13f 100644
--- a/regen/
+++ b/regen/
@@ -649,7 +649,8 @@ END_OF_DESCR
     while (<$oldguts>) {
         last if /=for end/;
-    do { print } while <$oldguts>;
+    do { print } while <$oldguts>; #win32 can't unlink an open FH
+    close $oldguts or die "Error closing pod/perldebguts.pod: $!";
     select $old_fh;

Perl5 Master Repository Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at | Group listing | About