develooper Front page | perl.perl5.build | Postings from March 2004

Re: [PATCH] Move Win32.pm/Win32.xs from libwin32 module to core Perl

Thread Next
From:
H.Merijn Brand
Date:
March 21, 2004 04:33
Subject:
Re: [PATCH] Move Win32.pm/Win32.xs from libwin32 module to core Perl
Message ID:
20040321132954.0304.H.M.BRAND@hccnet.nl
On Sun 21 Mar 2004 06:05, Yitzchak Scott-Thoennes <sthoenna@efn.org> wrote:
> On Thu, Mar 18, 2004 at 01:13:49PM -0800, Jan Dubois <jand@activestate.com> wrote:
> > On Wed, 30 Jul 2003 18:36:54 -0700, Jan Dubois <jand@ActiveState.com> wrote:
> > 
> > >On Wed, 30 Jul 2003 18:12:22 -0700, Gurusamy Sarathy
> > ><gsar@ActiveState.com> wrote:
> > >
> > >>On Wed, 30 Jul 2003 16:42:22 PDT, Michael G Schwern wrote:
> > >>>I'd tend to agree, the line between win32.c and libwin32 seems artificial.  
> > >>>It also looks like libwin32 is practically a necessity to get anything 
> > >>>interesting done on Win32. What say, Jarkko of Borg and Sarathy of State?
> > >>
> > >>I don't think all of libwin32 belongs in the core.  The parts that
> > >>are documented in Win32.pod should certainly be added to the core,
> > >>as we've discussed in the past:
> > >>
> > >>  http://www.xray.mpe.mpg.de/mailing-lists/perl5-porters/2003-01/msg00381.html
> > >>
> > >>I haven't seen any patches, though.
> > >
> > >I can look into moving Win32.pm/Win32.xs (but nothing else) into the core.
> > >This should happen *after* 5.8.1 and libwin32 0.20 have been released.
> > >Hectic patching right now will just create a mess.
> > 
> > Ok, I've finally remembered to do this.  In addition to the patches included
> > below, the following files need to be *added*:
> > 
> >   win32/ext/Win32/Makefile.PL
> >   win32/ext/Win32/Win32.pm
> >   win32/ext/Win32/Win32.xs
> > 
> > They are all included in the attached tarball.  Please also *delete* the file
> > 
> >   lib/Win32.pod
> > 
> > The documentation is now included in Win32.pm.
> > 
> > The included Win32 module also contains the new Win32::IsAdmin() function
> > supplied by Steve Hay.
> 
> I'd like to have Win32/ under the main ext/ directory instead, with a
> patch to Configure to exclude it.  This will make it easier to patch
> things to get Win32 built for cygwin also (which I hope to see happen
> in the not-too-distant future

Moved to the perl5-build list

Color me unix centered if you like, but to be honoust I don't have the
faintest idea what you're talking about :)

I'm the Configure pumpking/maintainer, and open to every improvement, but I
first want to understand what and why

The current state is that OS specific stuff is in root/OS, like VMS, OS2 and
win32. I don't see (yet) why win32 should be moved to ext/

What do I miss?

-- 
H.Merijn Brand        Amsterdam Perl Mongers (http://amsterdam.pm.org/)
using perl-5.6.1, 5.8.0, & 5.9.x, and 806 on  HP-UX 10.20 & 11.00, 11i,
   AIX 4.3, SuSE 8.2, and Win2k.           http://www.cmve.net/~merijn/
http://archives.develooper.com/daily-build@perl.org/   perl-qa@perl.org
send smoke reports to: smokers-reports@perl.org, QA: http://qa.perl.org


Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About