develooper Front page | perl.perl5.build | Postings from March 2004

Re: runmakedepend patch

Thread Previous | Thread Next
From:
H.Merijn Brand
Date:
March 20, 2004 03:23
Subject:
Re: runmakedepend patch
Message ID:
20040320121806.0301.H.M.BRAND@hccnet.nl
On Fri 19 Mar 2004 21:05, Andrew Dougherty <doughera@lafayette.edu> wrote:
> On Fri, 19 Mar 2004, H.Merijn Brand wrote:
> 
> > On Fri 19 Mar 2004 18:51, Andrew Dougherty <doughera@lafayette.edu> wrote:
> > > On Wed, 17 Mar 2004, H.Merijn Brand wrote:
> > >
> > > > In implementing Nicholas' wish, I hit a point where I reach success for
> > > > 'metaconfig -m' which creates exactly what I want, but I'd like to silence
> > > > metalint too, which complaints like:
> > > >
> > > > --8<---
> > > > :
> > > >     Your private U/modified/yacc.U overrides the public one.
> > > > Extracting dependency lists from 814 units...
> > > > "/pro/3gl/CPAN/perl-current/U/all/Finish.U", line 41 (?S:): variable '$runmakedepend' is not listed on ?MAKE: line.
> > >
> > > I don't have a set of units set up to check, but I think this error
> > > message is really the key issue.  Try changing the MAKE line to
> > > ?MAKE:runmakedepend Finish: Chk_MANI Extract Myread Oldsym Magic_h cat rm contains \
> > >        test package make
> >
> > Tried that. This will cause a cyclic dependency error.
> 
> It will?  How?  What, exactly, will be the cyclic dependency?
> Sorry, but (without testing, I'll admit) this looks like the right
> solution.

--8<--- This patch
p4 -dpu diff
==== //depot/metaconfig/U/modified/Finish.U#5 - /pro/3gl/CPAN/metaconfig/U/modified/Finish.U ====
38c38
< ?MAKE:Finish: Chk_MANI Extract Myread Oldsym Magic_h cat rm contains \
---
> ?MAKE:runmakedepend Finish: Chk_MANI Extract Myread Oldsym Magic_h cat rm contains \
40a41,43
> ?S:runmakedepend:
> ?S:   This variable defines if Configure runs 'make depend'
> ?S:.
41a45
> ?INIT:runmakedepend=''
87c91,94
<       dflt=y
---
>       case "$runmakedepend" in
>               $undef|false|[nN]*) dflt='n' ;;
>               *) dflt='y' ;;
>       esac
-->8---

yields:
:
Extracting dependency lists from 814 units...
Sanity checks...
"End.U": stale ?MAKE: dependency '$W'.
Looking for dependency cycles...
    Cycle found for:
        (#1) Oldsym
        (#1) runmakedepend
        (#1) Config_h
        (#1) Magic_h
    Cycle involves:
        (?) End: runmakedepend
        (?) Config_h: End Config_sh
        (?) Config_sh: End
        (?) Oldsym: Config_sh
        (Finish) runmakedepend: Oldsym Magic_h
        (?) Magic_h: Config_h
Done.


And worse if I remove the ?INIT:

Extracting dependency lists from 814 units...
"/pro/3gl/CPAN/perl-current/U/all/Finish.U": variable '$runmakedepend' should have been set.
Sanity checks...
"End.U": stale ?MAKE: dependency '$W'.
Looking for dependency cycles...
    Cycle found for:
        (#1) Oldsym
        (#1) runmakedepend
        (#1) Config_h
        (#1) Magic_h
    Cycle involves:
        (?) End: runmakedepend
        (?) Config_h: End Config_sh
        (?) Config_sh: End
        (?) Oldsym: Config_sh
        (Finish) runmakedepend: Oldsym Magic_h
        (?) Magic_h: Config_h
Done.

-- 
H.Merijn Brand        Amsterdam Perl Mongers (http://amsterdam.pm.org/)
using perl-5.6.1, 5.8.0, & 5.9.x, and 806 on  HP-UX 10.20 & 11.00, 11i,
   AIX 4.3, SuSE 8.2, and Win2k.           http://www.cmve.net/~merijn/
http://archives.develooper.com/daily-build@perl.org/   perl-qa@perl.org
send smoke reports to: smokers-reports@perl.org, QA: http://qa.perl.org


Thread Previous | Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About