develooper Front page | perl.libwww | Postings from June 2003

Win32 bug in TEST

From:
tmetro
Date:
June 6, 2003 17:48
Subject:
Win32 bug in TEST
Message ID:
200306062238.h56Mc4p06573@smtp-2.mdc.net
When building LWP 5.69 on Win32, I get:

% nmake test
[...]
html/form.............No such field 'f' at html/form.t line 134
html/form.............dubious
        Test returned status 2 (wstat 512, 0x200)
DIED. FAILED tests 5, 10, 13-14
        Failed 4/14 tests, 71.43% okay


While investigating I noticed that if I ran TEST from the t directory, 
it worked, but from the main directory it failed. Giving it a spin in 
the debugger turned up a problem in this code:

    # fix all relative library locations
    foreach (@INC) {
	$_ = "../$_" unless m,^/,;
    }

which was killing the other library paths. Here's a patch that adds 
better Win32 compatibility:

---------------------------------------------------------------------
*** TEST        2003/06/06 21:44:01     1.1
--- TEST        2003/06/06 22:24:10     1.3
***************
*** 12,18 ****

      # fix all relative library locations
      foreach (@INC) {
!       $_ = "../$_" unless m,^/,;
      }
  }
  # Pick up the library files from the ../blib directory
--- 12,18 ----

      # fix all relative library locations
      foreach (@INC) {
!       $_ = "../$_" unless m!^(/|[A-Za-z]{1,2}:)!;
      }
  }
  # Pick up the library files from the ../blib directory
---------------------------------------------------------------------

 -Tom

-- 
Tom Metro                                         
Venture Logic                Please send plain text email only.
Newton, MA, USA    HTML email will be delayed by up to 30 days.




nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About