develooper Front page | perl.libnet | Postings from July 2002

non-backwards compatible change in Net::SMTP: #685

From:
Jan Pieter Cornet
Date:
July 9, 2002 12:47
Subject:
non-backwards compatible change in Net::SMTP: #685
Message ID:
20020709194657.GC61874@xs4all.nl
We've just been bitten by change #685 for Net::SMTP, after upgrading
libnet on our production machines. Instead of doing the HELO greeting
with the local hostname, they suddenly used "localhost.localdomain",
which caused some clients' spam filters to kick in and reject all
their email.

The fix was very obvious, and is already installed, but I'm left
wondering... Why was this non-backward compatible change necessary? Why
wasn't it documented more careful (the Net::SMTP pod docs remained
EXACTLY the same in this respect, this is only "documented" in
ChangeLog). And finally: was there any discussion about this? I haven't
seen anything on perl-libnet.

(I figured a better patch would be to use "localhost.localdomain"
instead of the empty string in case no fqdn for the current host could
be found, but keep the Net::Domain::hostfqdn() call).

But it's probably too late now, since this was changed in 1.10 already...
(the reason we only upgrade now is probably because there hasn't been
a FreeBSD /usr/ports update until recently ;)

Constructive-criticising'ly-yours,

-- 
#!perl -pl	# This kenny-filter is virus-free as long as you don't copy it
$p=3-2*/[^\W\dmpf_]/i;s.[a-z]{$p}.vec($f=join('',$p-1?chr(sub{$_[0]*9+$_[1]*3+
$_[2]}->(map{/p|f/i+/f/i}split//,$&)+97):('m',p,f)[map{((ord$&)%32-1)/$_%3}(9,
3,1)]),5,1)='`'lt$&;$f.eig;				   # Jan-Pieter Cornet



nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About