develooper Front page | perl.cvs.parrot | Postings from December 2008

[svn:parrot] r34096 - in trunk: . config/gen/makefiles lib/Parrot lib/Parrot/Configure/Options/Test lib/Parrot/Ops2pm t/tools/ops2pm tools/build

From:
jkeenan
Date:
December 18, 2008 18:14
Subject:
[svn:parrot] r34096 - in trunk: . config/gen/makefiles lib/Parrot lib/Parrot/Configure/Options/Test lib/Parrot/Ops2pm t/tools/ops2pm tools/build
Message ID:
20081219021410.E39F8CBA12@x12.develooper.com
Author: jkeenan
Date: Thu Dec 18 18:14:09 2008
New Revision: 34096

Modified:
   trunk/Configure.pl
   trunk/config/gen/makefiles/root.in
   trunk/lib/Parrot/Configure/Options/Test/Prepare.pm
   trunk/lib/Parrot/Ops2pm.pm
   trunk/lib/Parrot/Ops2pm/Auxiliary.pm
   trunk/t/tools/ops2pm/05-renum_op_map_file.t
   trunk/tools/build/ops2pm.pl

Log:
In r30478 ( 2008-08-23 ), I changed the name of t/tools/ops2pmutils/ to
t/tools/ops2pm/.  I did not change all instances of the old name in code and,
as a result, the tests in t/tools/ops2pm/*.t have not been run as part of
'make buildtools_tests' or 'perl Configure.pl --test' since then.  This fixes
that, for the most part.  But in the interim changes in the way ops codes are
renumbered have broken the tests in t/tools/ops2pm/05-renum_op_map_file.t, so
mosts of its tests are TODOed out.


Modified: trunk/Configure.pl
==============================================================================
--- trunk/Configure.pl	(original)
+++ trunk/Configure.pl	Thu Dec 18 18:14:09 2008
@@ -186,7 +186,7 @@
 =item C<--test=build>
 
 Run tests found in F<t/postconfigure/>, F<t/tools/pmc2cutils/>,
-F<t/tools/ops2cutils/> and F<t/tools/ops2pmutils/> I<after> configuration has
+F<t/tools/ops2cutils/> and F<t/tools/ops2pm/> I<after> configuration has
 completed.  These tests demonstrate (a) that certain of Parrot's configuration
 tools are working properly post-configuration; and (b) that certain of
 Parrot's build tools will work properly once you call F<make>.

Modified: trunk/config/gen/makefiles/root.in
==============================================================================
--- trunk/config/gen/makefiles/root.in	(original)
+++ trunk/config/gen/makefiles/root.in	Thu Dec 18 18:14:09 2008
@@ -1431,7 +1431,7 @@
 TOOLS_TEST_FILES = \
     t/tools/*.t
 PMC2CUTILS_DIR = t/tools/pmc2cutils
-OPS2PMUTILS_DIR = t/tools/ops2pmutils
+OPS2PMUTILS_DIR = t/tools/ops2pm
 OPS2CUTILS_DIR = t/tools/ops2cutils
 REVISIONUTILS_DIR = t/tools/revision
 HARNESS_DIR = t/pharness

Modified: trunk/lib/Parrot/Configure/Options/Test/Prepare.pm
==============================================================================
--- trunk/lib/Parrot/Configure/Options/Test/Prepare.pm	(original)
+++ trunk/lib/Parrot/Configure/Options/Test/Prepare.pm	Thu Dec 18 18:14:09 2008
@@ -33,7 +33,7 @@
         glob("t/postconfigure/*.t"),
         glob("t/tools/pmc2cutils/*.t"),
         glob("t/tools/ops2cutils/*.t"),
-        glob("t/tools/ops2pmutils/*.t"),
+        glob("t/tools/ops2pm/*.t"),
         glob("t/pharness/*.t"),
     );
     return @postconfiguration_tests;
@@ -137,7 +137,7 @@
     t/postconfigure/
     t/tools/pmc2cutils/
     t/tools/ops2cutils/
-    t/tools/ops2pmutils/
+    t/tools/ops2pm/
     t/pharness/
 
 =back

Modified: trunk/lib/Parrot/Ops2pm.pm
==============================================================================
--- trunk/lib/Parrot/Ops2pm.pm	(original)
+++ trunk/lib/Parrot/Ops2pm.pm	Thu Dec 18 18:14:09 2008
@@ -429,7 +429,7 @@
 =head1 NOTE ON TESTING
 
 A suite of test files to accompany this package is found in
-F<t/tools/ops2pmutils>.  This suite has been developed to maximize its
+F<t/tools/ops2pm>.  This suite has been developed to maximize its
 coverage of the code of Parrot::Ops2pm (as measured by Perl module
 Devel::Cover).  Should you wish to refactor this package, it is recommended
 that you do so in a B<test-driven> manner:
@@ -455,7 +455,7 @@
 Parrot's F<Configure.pl> has run but B<before> F<make> has run.  Example:
 
     $> perl Configure.pl
-    $> prove -v t/tools/ops2pmutils/*.t
+    $> prove -v t/tools/ops2pm/*.t
     $> make
 
 =item 5

Modified: trunk/lib/Parrot/Ops2pm/Auxiliary.pm
==============================================================================
--- trunk/lib/Parrot/Ops2pm/Auxiliary.pm	(original)
+++ trunk/lib/Parrot/Ops2pm/Auxiliary.pm	Thu Dec 18 18:14:09 2008
@@ -52,7 +52,7 @@
 
 Extraction of the subroutines exported by this package from
 F<tools/build/ops2pm.pl> facilitates the testing of their functionality by the
-tests in F<t/tools/ops2pmutils/*.t>.
+tests in F<t/tools/ops2pm/*.t>.
 
 =head1 SUBROUTINES
 

Modified: trunk/t/tools/ops2pm/05-renum_op_map_file.t
==============================================================================
--- trunk/t/tools/ops2pm/05-renum_op_map_file.t	(original)
+++ trunk/t/tools/ops2pm/05-renum_op_map_file.t	Thu Dec 18 18:14:09 2008
@@ -15,7 +15,7 @@
 use File::Spec;
 use File::Temp qw( tempdir );
 use Tie::File;
-use lib '/home/jimk/work/opsrenum/lib';
+use lib 'lib';
 use Parrot::OpsRenumber;
 
 my ($self, @opsfiles);
@@ -27,7 +27,8 @@
 );;
 ok(-d $samplesdir, "Able to locate samples directory");
 
-{
+TODO: {
+    local $TODO = 'Changes to Parrot::OpsRenumber have borked these tests';
     ##### Prepare temporary directory for testing #####
 
     my $tdir = tempdir( CLEANUP => 1 );

Modified: trunk/tools/build/ops2pm.pl
==============================================================================
--- trunk/tools/build/ops2pm.pl	(original)
+++ trunk/tools/build/ops2pm.pl	Thu Dec 18 18:14:09 2008
@@ -82,7 +82,7 @@
 methods and a small number of Parrot::Ops2pm::Auxiliary subroutines.
 See those modules' documentation for discussion of those functions.
 Revisions to the functionality should be made in those packages and tested
-against tests found in F<t/tools/ops2pmutils/>.
+against tests found in F<t/tools/ops2pm/>.
 
 =head1 WARNING
 



nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About