develooper Front page | perl.cvs.parrot | Postings from December 2008

[svn:parrot] r33787 - branches/testparrottest/lib/Parrot

From:
jkeenan
Date:
December 10, 2008 18:53
Subject:
[svn:parrot] r33787 - branches/testparrottest/lib/Parrot
Message ID:
20081211025315.332D4CBA89@x12.develooper.com
Author: jkeenan
Date: Wed Dec 10 18:53:14 2008
New Revision: 33787

Modified:
   branches/testparrottest/lib/Parrot/Test.pm

Log:
Delete internal sub _report_odd_hash().  All it provides is a smidgen more diagnostic than you would get with a regular 'die' message, but any competent Perl programmer should be able to figure out what has gone wrong.

Modified: branches/testparrottest/lib/Parrot/Test.pm
==============================================================================
--- branches/testparrottest/lib/Parrot/Test.pm	(original)
+++ branches/testparrottest/lib/Parrot/Test.pm	Wed Dec 10 18:53:14 2008
@@ -590,7 +590,6 @@
 }
 
 sub _run_test_file {
-    local $SIG{__WARN__} = \&_report_odd_hash;
     my ( $func, $code, $expected, $desc, %extra ) = @_;
     my $path_to_parrot = path_to_parrot();
     my $parrot = File::Spec->join( File::Spec->curdir(), 'parrot' . $PConfig{exe} );
@@ -707,21 +706,6 @@
     return ( $out_f, $cmd, $exit_code );
 }
 
-sub _report_odd_hash {
-    my $warning = shift;
-    if ( $warning =~ m/Odd number of elements in hash assignment/ ) {
-        require Carp;
-        my @args = DB::uplevel_args();
-        shift @args;
-        my $func = ( caller() )[2];
-
-        Carp::carp("Odd $func invocation; probably missing description for TODO test");
-    }
-    else {
-        warn $warning;
-    }
-}
-
 sub _handle_test_options {
     my $options = shift;
     # To run the command in a different directory.



nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About