develooper Front page | perl.cvs.parrot | Postings from December 2008

[svn:parrot] r33536 - branches/testparrottest/lib/Parrot

From:
jkeenan
Date:
December 5, 2008 20:24
Subject:
[svn:parrot] r33536 - branches/testparrottest/lib/Parrot
Message ID:
20081206042436.6AEBBCB9AF@x12.develooper.com
Author: jkeenan
Date: Fri Dec  5 20:24:35 2008
New Revision: 33536

Modified:
   branches/testparrottest/lib/Parrot/Test.pm

Log:
Insert some inline comments to help diagnose excessively long subroutine.

Modified: branches/testparrottest/lib/Parrot/Test.pm
==============================================================================
--- branches/testparrottest/lib/Parrot/Test.pm	(original)
+++ branches/testparrottest/lib/Parrot/Test.pm	Fri Dec  5 20:24:35 2008
@@ -181,13 +181,13 @@
 sub _run_test_file {
     local $SIG{__WARN__} = \&_report_odd_hash;
     my ( $func, $code, $expected, $desc, %extra ) = @_;
-my $incoming_desc_status;
-if ($desc) {
-    $incoming_desc_status++;
-    print STDERR "desc:  $desc\n";
-} else {
-    print STDERR "desc is Perl-false\n";
-}
+#my $incoming_desc_status;
+#if ($desc) {
+#    $incoming_desc_status++;
+#    print STDERR "desc:  $desc\n";
+#} else {
+#    print STDERR "desc is Perl-false\n";
+#}
 
     my $path_to_parrot = path_to_parrot();
     my $parrot = File::Spec->join( File::Spec->curdir(), 'parrot' . $PConfig{exe} );
@@ -200,13 +200,13 @@
         ( undef, my $file, my $line ) = caller();
         $desc = "($file line $line)";
     }
-unless ($incoming_desc_status) {
-    if ($desc) {
-        print STDERR "desc is now:  $desc\n";
-    } else {
-        print STDERR "desc is still Perl-false\n";
-    }
-}
+#unless ($incoming_desc_status) {
+#    if ($desc) {
+#        print STDERR "desc is now:  $desc\n";
+#    } else {
+#        print STDERR "desc is still Perl-false\n";
+#    }
+#}
 
     # $test_no will be part of temporary file
     my $test_no = $builder->current_test() + 1;
@@ -390,6 +390,7 @@
     my $pirc           = File::Spec->join( File::Spec->curdir(),
                             qw( compilers pirc ), "pirc$PConfig{exe}" );
 
+    ##### A: Parrot test map #####
     my %parrot_test_map = map {
         $_ . '_output_is'           => 'is_eq',
         $_ . '_error_output_is'     => 'is_eq',
@@ -440,7 +441,7 @@
                 return 0;
             }
 
-print STDERR 'just before $pass:  ', "$desc\n";
+#print STDERR 'just before $pass:  ', "$desc\n";
             my $pass = $builder->$meth( $real_output, $expected, $desc );
             $builder->diag("'$cmd' failed with exit code $exit_code")
                 if not $pass and $exit_code;
@@ -453,6 +454,7 @@
         *{ $package . '::' . $func } = $test_sub;
     }
 
+    ##### B: PIR-to-PASM test map #####
     my %pir_2_pasm_test_map = (
         pir_2_pasm_is      => 'is_eq',
         pir_2_pasm_isnt    => 'isnt_eq',
@@ -548,6 +550,7 @@
         *{ $package . '::' . $func } = $test_sub;
     }
 
+    ##### C: Language test map #####
     my %builtin_language_prefix = (
         PIR_IMCC  => 'pir',
         PASM_IMCC => 'pasm',
@@ -613,6 +616,7 @@
         *{ $package . '::' . $func } = $test_sub;
     }
 
+    ##### D:  Example test map #####
     my %example_test_map = (
         example_output_is   => 'language_output_is',
         example_output_like => 'language_output_like',
@@ -656,6 +660,7 @@
         *{ $package . '::' . $func } = $test_sub;
     }
 
+    ##### E: C test map #####
     my %c_test_map = (
         c_output_is   => 'is_eq',
         c_output_isnt => 'isnt_eq',



nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About