develooper Front page | perl.beginners | Postings from September 2009

Using named params

Thread Next
From:
Steve Bertrand
Date:
September 25, 2009 17:18
Subject:
Using named params
Message ID:
4ABD5DDB.9020700@ibctech.ca
Hi all,

I've read a fair bit about named params, and have been hit by bugs by
overlapping lists into hashes etc.

Below is a method that essentially isn't truly a 'captcha', but is
something I use to 'ensure' that the person clicking the submit button
on a web gui isn't clicking by accident. This was to avoid having to
write intermediary "Confirm" stages for potentially dangerous actions.
(this is all for internal staff... if they fsck things up after this
stage, they get to rewrite things themselves ;)

Instead of re-writing the code continuously, I finally decided to just
move it to the base class.

I'm concerned about how I slurp in my params. For some reason, it
'feels' very dangerous to me.

Can someone recommend the reading I need to do to ensure that I've been
over the possible ramifications? IOW, I'd like to spend more time
learning about the type of params one should use, when they should be
used, and when certain param types MUST be used (irt standard types, and
refs).

Just to include some code:

sub captcha {

    my $self    = shift;
    my %params  = @_;

    if ( ! %params ) {

        my $captcha_length = $self->CAPTCHA_LENGTH();

        my $captcha;

        for ( 1 .. $captcha_length ) {
            $captcha .= int( rand( 10 ));
        }

        return $captcha;
    }

    my $captcha = $params{ -captcha };
    my $input   = $params{ -input };

    if ( ! $captcha || ! $input ) {
        return 1;
    }

    if ( $captcha eq $input ) {
        return $captcha;
    }

    return 0;
}

Steve

Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About