develooper Front page | perl.beginners | Postings from September 2009

Requesting peer review...

Thread Next
Steve Bertrand
September 20, 2009 15:30
Requesting peer review...
Message ID:
Hi everyone,

On my ISP project, I've done a personal 'code freeze'. My objective is
to go through every sub and ensure tests and POD are accurate. Where
they are not, I'll (re)write them.

During this procedure, I noticed that many methods did not have decent
return values... so I added them.

I know it's much to ask, but I'm asking for review on my 'style'. I want
to ensure that what I do is understandable to most.

If you have time to do a quick browse, I'm looking to know:

- does the POD make sense
- does my coding writing style look ok (I still haven't found my style yet)
- if my tests are ok

With that said, I'd like to say:

- forgive the dirty way that I munge the sym table. I'll be changing this
- my tests were written hastily. I'm finding it hard to put tests into a
test file and not into a 'throwaway' file.

I do want feedback/advice. I especially want advice on writing tests.

Please be harsh. Although it's sometimes hard to swallow, I learn best
when comments are direct, accurate, and truthful (thanks Uri).



ps. ISP::Error was first up, due to alphabetical order. Feedback on this
module will pave my way for future progress.

pps. Thanks. If you've read this far, you've probably done review. I am
ready to be broken, and brought back up.

Thread Next Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at | Group listing | About