Re: [PATCH] prepend auth_flat plugin name to $note

On Sun, Apr 22, 2012 at 2:25 PM, Matt Simerson <matt@tnpi.net> wrote:

> Makes it much easier to figure out where that log entry came from.
> ---
> t/plugin_tests/auth/auth_flat_file |    2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/t/plugin_tests/auth/auth_flat_file
> b/t/plugin_tests/auth/auth_flat_file
> index c4218bd..6726307 100644
> --- a/t/plugin_tests/auth/auth_flat_file
> +++ b/t/plugin_tests/auth/auth_flat_file
> @@ -19,7 +19,7 @@ sub test_auth_flat_file {
>    for $u ( @u_list ) {
>        ( $a,$r,$p ) = @{$u_data{$u}};
>        ($ret, $note) = $self->auth_flat_file($tran,'CRAMMD5',$a,$p);
> -       defined $note or $note='No-Message';
> +       defined $note or $note='authflat: No-Message';
>

Would it be clear to use the full name of the plugin?  What if you have
multiple plugins with a similar name?


>        is ($ret, $r, $note);
>        # - for debugging.
>        # warn "$note\n";
> --
> 1.7.9.6
>
>

• [PATCH] prepend auth_flat plugin name to $note by Matt Simerson
• Re: [PATCH] prepend auth_flat plugin name to $note by Robert Spier
• Re: [PATCH] prepend auth_flat plugin name to $note by Matt Simerson
• Re: [PATCH] prepend auth_flat plugin name to $note by Robert Spier