Front page | perl.qa |
Postings from December 2009
Joshua ben Jore wrote:
>> Fortunately there is one key location where MakeMaker does almost all its
>> writing to disk, ExtUtils::MakeMaker->flush. A simple patch to check that
>> would be lovely. If you want to write and insert a safe _print() wrapper
>> method and scatter that around that's fine, too.
>
> I already clawed my eyes out years ago. In the middle of this, note
> ae5f97d4cf9f314a96d68af2b6fcc6ee1c7cad26 which checks
> ExtUtils::MakeMaker->flush. Pushed the below to
> http://github.com/jbenjore/extutils-makemaker.
The problem with this approach, and I'm sorry you did all that work, is that
it complicates the code and it'll won't be maintained without effort. The
next patch will forget to include the cumbersome "or die ..." logic. When you
have to scatter duplicated code all over to warn about an unrecoverable
failure in the surrounding environment... well hell, when you have to scatter
duplicated code all over that's bad, full stop.
I'm very sorry but I have to reject most of that work. I feel like a dick for
doing it.
A little experimentation with a small disk image shows that close() will error
if there's no disk left. No need to check every print. And a close() wrapper
is trivial. It does mean there needs to be a close() for every open() which
is annoying but less so. Though I may have found a non-invasive way for
autodie to take care of that, it doesn't help us.
https://rt.cpan.org/Ticket/Display.html?id=52985
I'm not going to ask you to write up that patch, I'll do it myself unless
somebody gets to it first. I probably won't have time to touch it until
tomorrow if you're feeling frisky.
>> MakeMaker's version control is listed in the META.yml and on
>> search.cpan.org.
>
> I looked in http://search.cpan.org/dist/ExtUtils-MakeMaker/lib/ExtUtils/MakeMaker.pm#AUTHORS
> and found no mention of a repository so I assume it was as-yet
> undocumented.
Just letting you know that search.cpan.org tracks that stuff now for future
use. I'll add a link to the POD. Thanks for mentioning it.
--
170. Not allowed to "defect" to OPFOR during training missions.
-- The 213 Things Skippy Is No Longer Allowed To Do In The U.S. Army
http://skippyslist.com/list/
Thread Previous
|
Thread Next