develooper Front page | perl.ponie.dev | Postings from April 2005

Re: [PATCH] Refactoring to Sv*_set() macros - patch #2

Thread Previous | Thread Next
From:
Tim Bunce
Date:
April 11, 2005 03:38
Subject:
Re: [PATCH] Refactoring to Sv*_set() macros - patch #2
Message ID:
20050411103743.GA99435@dansat.data-plan.com
On Sun, Apr 10, 2005 at 08:31:48PM -0500, Steve Peters wrote:
> On Sun, Apr 10, 2005 at 10:54:01PM +0100, Tim Bunce wrote:
> > On Thu, Apr 07, 2005 at 01:51:49PM -0500, Steve Peters wrote:
> > > Attached is the second in a series of patches to migrate the Perl core
> > > to using the Sv*_set() macros.  This patch converts assignments to 
> > > SvIVX() to SVIV_set().
> > > 
> > > Please note that this patch does contain changes to various core modules as
> > > well as the code to in the Perl executable.  I've currently held off on 
> > > updating the module versions until these patches are completed.  Also, 
> > > Encode was turned up as a module to modify with these changes, but I will 
> > > include that change in a separate email to the Encode maintainer.
> > > 
> > > Questions, comments, and complaints are all appreciated.
> > 
> > Good work - thanks.
> > 
> > Will you be making matching mods to ./ext/Devel/PPPort/* ?
>
> I didn't see any actual changes required for ./ext/Devel/PPPort/*, but I will
> take a second (and probably third) look to see if changes are needed.  I'll
> check with Marcus and others, as well, since my knowledge of the Perl core
> is still pretty weak.

Thanks.

If assignments to SvIVX() are to be replaced with SVIV_set() then any
extensions that assign to SvIVX() will also need to be changed to use
SVIV_set().

In order that the extensions can still build for old versions of perl
the SVIV_set() macro needs to be added to PPPort.

Tim.

p.s. The DBI does scary things by taking the address of the integer
result of SvIVX()! But I'll worry about that another day...

Thread Previous | Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About