develooper Front page | perl.php.sandwich.dev | Postings from June 2005

[svn:PHP-Sandwich] rev 1073 - PHP-Sandwich/trunk

From:
gschlossnagle
Date:
June 7, 2005 07:39
Subject:
[svn:PHP-Sandwich] rev 1073 - PHP-Sandwich/trunk
Message ID:
20050607143951.31941.qmail@x1.develooper.com
Author: gschlossnagle
Date: Tue Jun  7 07:39:51 2005
New Revision: 1073

Modified:
   PHP-Sandwich/trunk/PHP.xs
Log:
This should be safe to drop - fully redundant code.


Modified: PHP-Sandwich/trunk/PHP.xs
==============================================================================
--- PHP-Sandwich/trunk/PHP.xs	(original)
+++ PHP-Sandwich/trunk/PHP.xs	Tue Jun  7 07:39:51 2005
@@ -404,77 +404,6 @@ SV *SAND_call(method_name, interp, ...)
           goto cleanup;
         } else {
           RETVAL = newSVzval(retval, interp);
-          /*
-          switch(retval->type) {
-            case IS_NULL:
-              RETVAL = &PL_sv_undef;
-              break;
-            case IS_LONG:
-            case IS_BOOL:
-            case IS_DOUBLE:
-            case IS_STRING:
-              RETVAL = newSVzval(retval, interp);
-              break;
-            case IS_ARRAY:
-              RETVAL = newSVzval(retval, interp);
-              break;
-            case IS_OBJECT: 
-              {
-                char *name;
-                zend_uint namelen;
-                char objectname[MAXPATHLEN];
-                HV *h1, *package;
-                SV * c1;
-                PHP_Class pclass;
-  
-                c1 = newSV(0);
-                pclass = malloc(sizeof(*pclass));
-                pclass->val = retval;
-                pclass->interp = interp;
-                sandwich_interp_inc_ref(interp);
-                if(get_class_name(retval, &name, &namelen) < 0) {
-                  name = "UNKNOWN";
-                } 
-                snprintf(objectname, MAXPATHLEN, "PHP::Class::%s", name);
-                sv_setref_pv(c1, "PHP::Class", (void *) pclass);
-                h1 = (HV *)sv_2mortal((SV *)newHV());
-                hv_magic(h1, (GV*)c1, PERL_MAGIC_tied);
-                sv_magic((SV *)h1, c1, PERL_MAGIC_ext, NULL, -1);
-                RETVAL = newRV((SV *)h1);
-                package = gv_stashpv(objectname, TRUE);
-                {
-                  char objectisa[MAXPATHLEN];
-                  package = gv_stashpv(objectname, 1);
-                  snprintf(objectisa, MAXPATHLEN, "PHP::Class::%s::ISA", name);
-                  //if(get_av(objectisa, FALSE)) {
-                    av_push(get_av(objectisa, TRUE),
-                            newSVpv("PHP::Class", 0));
-                  //}
-                }
-                RETVAL = sv_bless(RETVAL, package);
-              }
-              break;
-            case IS_RESOURCE:
-                {
-                  SV * c1;
-                  PHP_Resource prsrc;
-  
-                  c1 = newSV(0);
-                  prsrc = malloc(sizeof(*prsrc));
-                  prsrc->val = retval;
-                  sandwich_interp_inc_ref(interp);
-                  prsrc->interp = interp;
-                  RETVAL = newSV(0);
-                  sv_setref_pv(c1, "PHP::Resource", (void *) prsrc);
-                  sv_magic(RETVAL, c1, PERL_MAGIC_tiedscalar, NULL, 0);
-                }
-              break;
-            default:
-              fprintf(stderr, "unsupported return type in PHP_Interpreter_call\n");
-              RETVAL = &PL_sv_undef;
-              break;
-          }
-          */
         }
   cleanup:
         zval_dtor(&method);



nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About