develooper Front page | perl.perl6.internals | Postings from February 2002

Re: [Patch] Yet more warnings-fixes and cleanups

Thread Previous
From:
Steve Fink
Date:
February 18, 2002 11:09
Subject:
Re: [Patch] Yet more warnings-fixes and cleanups
Message ID:
20020218190917.GC29422@foxglove.digital-integrity.com
On Mon, Feb 18, 2002 at 01:52:24PM -0500, Josh Wilmes wrote:
> Index: include/parrot/pmc.h
> ===================================================================
> RCS file: /home/perlcvs/parrot/include/parrot/pmc.h,v
> retrieving revision 1.17
> diff -u -r1.17 pmc.h
> --- include/parrot/pmc.h	1 Feb 2002 00:03:42 -0000	1.17
> +++ include/parrot/pmc.h	18 Feb 2002 18:46:22 -0000
> @@ -59,18 +59,18 @@
>      /* The rest of the flags are for use by Parrot */
>  
>      /* Set if the PMC has a destroy method that must be called */
> -    PMC_active_destroy_FLAG	= 2 << 8,
> +    PMC_active_destroy_FLAG = 2 << 8,
>      /* Set if the PMC can hold multiple PMCs. (Hash, array, list,
>         whatever) */
> -    PMC_is_container_FLAG	= 2 << 9,
> +    PMC_is_container_FLAG   = 2 << 9,
>      /* Set to true if the PMC data pointer points to something that
>         looks like a string or buffer pointer */
> -    PMC_is_buffer_ptr_FLAG	= 2 << 10,
> +    PMC_is_buffer_ptr_FLAG  = 2 << 10,
>      /* Set to true if the data pointer points to a PMC */
> -    PMC_is_PMC_ptr_FLAG		= 2 << 11,
> +    PMC_is_PMC_ptr_FLAG     = 2 << 11,
>      /* Set to true if the PMC has a private GC function. For PMCs the
>         GC system can't snoop into */
> -    PMC_private_GC_FLAG		= 2 << 12
> +    PMC_private_GC_FLAG     = 2 << 12
>  } PMC_flags;

Bleh, this stuff is still here? All of these should be 1 << n instead
of 2 << n.

After this patch goes in, I'll patch it unless someone else gets it first.

Thread Previous


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About