Front page | perl.perl6.internals |
Postings from January 2002
At 01:11 PM 1/22/2002 -0800, Steve Fink wrote: >On Tue, Jan 22, 2002 at 02:19:29PM -0500, Andy Dougherty wrote: > > diff -r -u parrot/include/parrot/packfile.h > parrot-andy/include/parrot/packfile.h > > --- parrot/include/parrot/packfile.h Mon Jan 7 17:09:15 2002 > > +++ parrot-andy/include/parrot/packfile.h Tue Jan 15 16:16:17 2002 > > @@ -44,7 +44,7 @@ > > struct PackFile_FixupTable * fixup_table; > > struct PackFile_ConstTable * const_table; > > size_t byte_code_size; > > - char * byte_code; > > + opcode_t * byte_code; > > }; > >I don't know anything about this part of the code, but your change >looks way better to me. Even if byte_code isn't purely an array of >opcode_t's, it's certainly much better than char*. I'd rather have >things that break with this change be fixed, assuming there are any. > >It would be nice if the test suite included runs of the prederef >dispatcher and the jit so we could have some confidence that changes >like this aren't horribly breaking things... (*hint*) From my Sparc programming days I would say immediately if something is messy with the alignment you'll get horrible death and SIGBUS. (really not specific to Sparc...) Of course the absence of this is not evidence of anything but... -MelvinThread Previous