develooper Front page | perl.perl6.internals | Postings from January 2002

Re: [PATCH] class/*.c weren't being compiled with warnings turnedon.

Thread Previous | Thread Next
From:
Simon Glover
Date:
January 15, 2002 12:52
Subject:
Re: [PATCH] class/*.c weren't being compiled with warnings turnedon.
Message ID:
Pine.GSO.4.10.10201152018430.2355-100000@muinntiarach.roe.ac.uk


On Tue, 15 Jan 2002, Dan Sugalski wrote:

> At 04:39 PM 1/15/2002 +0000, Alex Gough wrote:
> >On Tue, 15 Jan 2002, Simon Glover wrote:
> >
> > >    warning: control reaches end of non-void function
> > >
> > >  I'm not sure what to do about the former. The latter generally seem to
> > >  arise from unimplemented methods. Accordingly, I've added a new
> > >  exception, PMC_FN_NOT_IMPLEMENTED, to exception.h, and I'm working on
> > >  getting all of the currently unimplemented methods to throw this
> > >  exception. Patches below to exception.h and to perlnum.pmc - patches
> > >  for the other PMCs will follow shortly.

> >In general we should let things inherit from default.pmc, which can then
> >explode in the correct manner or do something sensible in terms of the
> >other behaviours of the pmc.  Adding "not implemented" code to every
> >pmc type is pointless duplication and certainly not the right way to
> >halt compiler warnings.
>
> Definitely. This is the way we should go with methods that are unchanged
> from the parent. (In this case the exception throw)
>

 Fair point; I'll patch it this way if I get a chance (which won't, alas,
 happen for a couple of days).

 Simon



Thread Previous | Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About