develooper Front page | perl.perl6.internals | Postings from January 2002

Re: [PATCH] class/*.c weren't being compiled with warningsturned on. [APPLIED]

Thread Previous | Thread Next
From:
Dan Sugalski
Date:
January 15, 2002 08:15
Subject:
Re: [PATCH] class/*.c weren't being compiled with warningsturned on. [APPLIED]
Message ID:
5.1.0.14.2.20020115111556.020157b8@pop.sidhe.org
At 11:17 PM 1/14/2002 +0000, Nicholas Clark wrote:
>On Sun, Jan 13, 2002 at 02:14:08PM -0500, Dan Sugalski wrote:
> > So, I'm turning off the unused parameter warning for now to shut the .ops
> > file compiles up. After that point, all submitted patches must generate no
> > more warnings than were currently being generated, and all submitted
> > patches must *not* generate warnings in the areas they patch.
>
>According to the letter of that, this patch isn't acceptable because it
>causes warnings not previously seen to appear.

It's definitely the right thing to do, though. Applied.

					Dan

--------------------------------------"it's like this"-------------------
Dan Sugalski                          even samurai
dan@sidhe.org                         have teddy bears and even
                                      teddy bears get drunk


Thread Previous | Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About