develooper Front page | perl.perl6.internals | Postings from October 2001

[PATCH] broken configure/make on win32

Thread Next
From:
Davíð Helgason
Date:
October 16, 2001 17:17
Subject:
[PATCH] broken configure/make on win32
Message ID:
MBBBKGHHIOBKPAKDJADPEEINCHAA.david@panmedia.dk
perl Configure.pl breaks on my win98. The offending line(s) are :)

> # Temporary hack
> system("make include/parrot/vtable.h");

(I just got it out of cvs, but if I am doing sth stupid please tell me)

So I decided to try to fix it.


My changes are

- Configure.pl:

I added a prompt for a make-program (which would be nmake in my case). The
extra change in prompt() is to remove a warning I got. Also changed a
system() call to use the prompted for makefile.

- Makefile.in

${make} instead of 'make'. There are still three problem lines in it, all of
them being cd <path>; ${make} <sth>. I don't know how to fix this - make was
never a big interest, I must admit.


I really don't know if this patch is acceptable, and don't have a developed
gut-feeling on the subject, this being my first perl6 patch (yeay!). If not,
please tell me why and I'll do my best to fix it.

This still is not all, because VC++ doesn't have "sys/time.h" anywhere, so I
still don't compile. But it's closer now.




But here goes (cvs diff). Is this usable?


d.

#############################################3

diff -r1.28 Configure.pl
106a107
> prompt("And your make program?", 'make', 'make');
192c193
< system("make include/parrot/vtable.h");
---
> system("$c{make} include/parrot/vtable.h");
244c245
< 	my($message, $field)=(@_);
---
> 	my($message, $field, $default)=(@_);
245a247
> 	$c{$field} = $default unless exists $c{$field};

#############################################3

diff -r1.27 Makefile.in
43c43
< 	cd examples/assembly; make mops.pbc
---
> 	cd examples/assembly; ${make} mops.pbc
97c97
< 	cd docs; make
---
> 	cd docs; ${make}
104c104
< 	cd docs; make clean
---
> 	cd docs; ${make} clean


Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About