[perl #112786] build broken under clang++

On Sun May 06 16:48:53 2012, craigberry wrote:
> clang++ seems to need only an extra set of parentheses to calm down
>    and let go of its anxieties:
> 
> % git diff
> diff --git a/sv.c b/sv.c
> index 3ac2fd8..1713977 100644
> --- a/sv.c
> +++ b/sv.c
> @@ -13966,7 +13966,7 @@ Perl_varname(pTHX_ const GV *const gv, const
>    char gvtype, PADOFFSET targ,
>         }
>      }
>      else {
> -       CV * const cv = gv ? (CV *)gv : find_runcv(NULL);
> +       CV * const cv = gv ? ((CV *)gv) : find_runcv(NULL);
>         SV *sv;
>         AV *av;
> 
> [snip]
> 
> IMO, something like this ought to go in for 5.16.0 because it is a
>    build failure, and clang++ is a compiler,[1] and someone not
>    knowing any better might try to compile Perl with it.
> 
> Those dozens or hundreds of you who actually use C++ at the day job
>    and/or know something about C++ parsing rules may want to chime in
>    about whether clang++ has gone slightly bonkers or is just living
>    out its identity as its own eccentric, hypersensitive C++ self.
> 
> [1]  Thanks to Apple's XCode, an increasingly ubiquitous one.
> 

Thank you.  Applied as ef5eb41.

-- 

Father Chrysostomos


---
via perlbug:  queue: perl5 status: open
https://rt.perl.org:443/rt3/Ticket/Display.html?id=112786

• [perl #112786] build broken under clang++ by Father Chrysostomos via RT