Front page | perl.perl5.porters |
Postings from May 2012
Re: [perl #111856] use overload fallback = 0 doesn't seem to always work
Thread Previous
|
Thread Next
From:
Rafael Garcia-Suarez
Date:
May 23, 2012 00:05
Subject:
Re: [perl #111856] use overload fallback = 0 doesn't seem to always work
Message ID:
CAMoYMM__YB_8GUfF_y=Rptwp9Lk8p7BBO4gj0XdDVVuzMHkygQ@mail.gmail.com
On 23 May 2012 05:49, Karl Williamson <public@khwilliamson.com> wrote:
> On 05/22/2012 09:34 AM, Rafael Garcia-Suarez via RT wrote:
>>
>> On 11 April 2012 06:06, Karl Williamson<public@khwilliamson.com> wrote:
>>>
>>> On 04/10/2012 09:31 AM, Karl Williamson wrote:
>>>>
>>>>
>>>> On 04/10/2012 08:55 AM, Rafael Garcia-Suarez via RT wrote:
>>>>>
>>>>>
>>>>> On 9 April 2012 07:00, Karl Williamson via
>>>>> RT<perlbug-followup@perl.org> wrote:
>>>>>>
>>>>>>
>>>>>> On Thu Mar 22 14:49:33 2012, perl.p5p@rjbs.manxome.org wrote:
>>>>>>>
>>>>>>>
>>>>>>> * Rafael Garcia-Suarez<rgs@consttype.org> [2012-03-20T05:59:56]
>>>>>>>>
>>>>>>>>
>>>>>>>> I pushed a fix for this to branch rgs/overload. I strongly think
>>>>>>>> that
>>>>>>>> more tests are needed in general from overload. (I guess it will be
>>>>>>>> for 5.17)
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> Thanks, I've added this to early-5.17-stuff.
>>>>>>>
>>>>>>
>>>>>> I have tried testing this by switching to this branch. mktables (which
>>>>>> had the original problem) fails to compile because of a missing
>>>>>> overloaded op. When I comment out the single heredoc that caused this
>>>>>> problem, mktables appears to work fine, but the result file,
>>>>>> lib/unicore/lib/Gc/Cs.pl, is now very wrong. That appears to be the
>>>>>> only file in error. It is supposed to be one range, the surrogates.
>>>>>>
>>>>>> I suppose what could be going on is that an op that previously was
>>>>>> auto-generated is now not, but now there is a base class op that gets
>>>>>> used instead. and that op is wrong.
>>>>>>
>>>>>> Does this seem like a possibility, or can you think of something else
>>>>>> that could be going wrong?
>>>>>
>>>>>
>>>>>
>>>>> Given that my patch only changes some code inside an if() condition, I
>>>>> would tend to think you did not build from a completely clean source
>>>>> tree ?
>>>>>
>>>>>
>>>>>
>>>>
>>>> It's completely reproducible on a clean blead. I have found the
>>>> particular Perl line that causes the problem, and will use the debugger
>>>> to single step through the overload calls sequence to see where things
>>>> go awry. Results to follow
>>>>
>>>
>>> It turns out it is entirely my bug. So, once 5.17 opens, I'll submit
>>> fixes
>>> for my portion first, then your patch.
>>
>>
>> I've committed a small fix to mktables in my branch rgs/overload after
>> having it rebased on top of blead :
>>
>> http://perl5.git.perl.org/perl.git/log/refs/heads/rgs/overload
>>
>> If it looks good I'm inclined to merge this branch in blead.
>>
>>
>>
>
> I have a local topic branch that includes your overload patch, among others,
> including things to update mktables to work with it. I haven't read your
> mktables patch, perhaps they are the same.
>
> I was planning to deliver the topic branch in the next couple weeks. I have
> no real objection to your committing earlier what you have, but it could
> make rebasing a little harder for me, so I suggest holding off.
The mktable patch is just a 2-line patch to separate stringification
and concatenation (because .= is no longer generated). I wanted to
merge my branch to shake out overload breakages in CPAN modules, but I
suppose I can already start building half of CPAN (tm) with blead + my
patch.
Thread Previous
|
Thread Next