develooper Front page | perl.perl5.porters | Postings from December 2011

Re: [perl #78708] use || not or! :-)

Thread Previous | Thread Next
From:
Ronald J Kimball
Date:
December 5, 2011 06:44
Subject:
Re: [perl #78708] use || not or! :-)
Message ID:
20111205144359.GA21278@penkwe.pair.com
On Mon, Dec 05, 2011 at 07:59:27AM +0000, hv@crypt.org wrote:
> "Alexandr Ciornii via RT" <perlbug-followup@perl.org> wrote:
> :index 634e891..90d8ece 100644
> :--- a/utils/h2xs.PL
> :+++ b/utils/h2xs.PL
> :@@ -893,7 +893,7 @@ if( @path_h ){
> :       }
> :       else {
> : 	# Work from miniperl too - on "normal" systems
> :-        my $SEEK_SET = eval 'use Fcntl qw/SEEK_SET/; SEEK_SET' or 0;
> :+        my $SEEK_SET = eval 'use Fcntl qw/SEEK_SET/; SEEK_SET' || 0;
> :         seek CH, 0, $SEEK_SET;
> :         my $src = do { local $/; <CH> };
> :         close CH;
> 
> Um, that's wrong too. You'll need parens.

It appears to parse as desired without the parens:

% perl -MO=Deparse,-p -e 'my $SEEK_SET = eval "use Fcntl qw/SEEK_SET/; SEEK_SET" || 0;'
(my $SEEK_SET = (eval('use Fcntl qw/SEEK_SET/; SEEK_SET') || 0));
-e syntax OK

Ronald

Thread Previous | Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About